Issue 654967 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	█ warx@chromium.org Last visit > 30 days ago
Closed:	Oct 2016
Cc:	sky@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	Bug

Move WidgetActivationWaiter to a common place for test support

Project Member Reported by warx@chromium.org, Oct 12 2016

Issue description

Now in code base, WidgetActivationWaiter is defined and used in two places.
In future, there might more usages.
Consider refactoring them to one common place such as widget_test.h

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2cab6d035bef91d027bbc642304eeeece680f62

commit a2cab6d035bef91d027bbc642304eeeece680f62
Author: warx <warx@chromium.org>
Date: Thu Oct 13 00:30:58 2016

Move WidgetActivationWaiter to a common place

BUG= 654967 
TEST=none

Review-Url: https://codereview.chromium.org/2409423003
Cr-Commit-Position: refs/heads/master@{#424920}

[modify] https://crrev.com/a2cab6d035bef91d027bbc642304eeeece680f62/chrome/browser/ui/libgtk2ui/select_file_dialog_interactive_uitest.cc
[modify] https://crrev.com/a2cab6d035bef91d027bbc642304eeeece680f62/ui/views/test/widget_test.cc
[modify] https://crrev.com/a2cab6d035bef91d027bbc642304eeeece680f62/ui/views/test/widget_test.h
[modify] https://crrev.com/a2cab6d035bef91d027bbc642304eeeece680f62/ui/views/widget/widget_interactive_uitest.cc

Comment 2 by warx@chromium.org, Oct 13 2016

Status: Fixed (was: Assigned)

Comment 3 by warx@chromium.org, Oct 13 2016

Status: Assigned (was: Fixed)

There still exists others, for example: https://cs.chromium.org/chromium/src/chrome/browser/extensions/api/tabs/tabs_test.cc?sq=package:chromium&l=855

Keep it open for now

Comment 4 by warx@chromium.org, Oct 25 2016

Status: Fixed (was: Assigned)

comment 3 actually needs BrowserActivationWaiter, so still close this issue.

►

Issue 654967 link

Issue metadata

Move WidgetActivationWaiter to a common place for test support

Issue description

Comment 1 by bugdroid1@chromium.org, Oct 13 2016

Comment 1 Deleted

Comment 2 by warx@chromium.org, Oct 13 2016

Comment 2 Deleted

Comment 3 by warx@chromium.org, Oct 13 2016

Comment 3 Deleted

Comment 4 by warx@chromium.org, Oct 25 2016

Comment 4 Deleted

Sign in to add a comment