New issue
Advanced search Search tips

Issue 654961 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Oct 2016
Cc:
atimo...@yandex-team.ru
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

MacViewsBrowser: Browser window flashes on Cmd+Shift+H.

Project Member Reported by karandeepb@chromium.org, Oct 12 2016 
Version: 56.0.2888.0
OS: Mac

What steps will reproduce the problem?
(1) Build with mac_views_browser=true
(2) Open browser.
(3) Press Cmd+Shift+H

What is the expected output?
Browser should navigate to the homepage w/o flashing.

What do you see instead?
Browser window flashes while navigating to the homepage.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b3fd8fa7e745eda9e69f49190f372aba03687d7

commit 2b3fd8fa7e745eda9e69f49190f372aba03687d7
Author: atimoxin <atimoxin@yandex-team.ru>
Date: Thu Oct 13 07:31:19 2016

MacViews: Don't set window's alpha to 0 if window is already visible.

Currently repeated calls to Show() a Widget cause a flash. This is because of
flag initial_visibility_suppressed_ in BridgedNativeWidget which was added in
r417863 to show some dialogs with an alpha value of 0 initially, till the
frames from the compositor arrive.

See  http://crbug.com/623950#c18 

To fix the problem this patch adds an additional check, so this logic would be
applied only if window isn't already visible.

BUG= 654961 

Review-Url: https://codereview.chromium.org/2407153004
Cr-Commit-Position: refs/heads/master@{#424974}

[modify] https://crrev.com/2b3fd8fa7e745eda9e69f49190f372aba03687d7/ui/views/cocoa/bridged_native_widget.mm

Comment 2 by karandeepb@chromium.org, Oct 20 2016

Owner: ----
Status: Fixed (was: Assigned)
►

Sign in to add a comment