New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 654955 link

Starred by 1 user
Status: Fixed
Owner:
█ dim...@chromium.org
Last visit > 30 days ago
Closed: Oct 2016
Cc:
petewil@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

For Download of pages, we need to wait for the page to load in foreground

Project Member Reported by dim...@chromium.org, Oct 12 2016 
This is a related to  bug 652889 , tracking changes to RecentTabHelper.

When user pressed Download button for the page, the tab helper will start observing the process of loading the page. If the good moment to snapshot a page will arise, it'll do so and tell RequestCoordinator. If such opportunity does not arise (tab renavigates or is closed) - it tells RequestCoordinator to work on that request. If Chrome is evicted from RAM, the RequestCoordinator picks up the request later.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02d38c0b50c55dadb98039dbc58a70ad2c7c8a15

commit 02d38c0b50c55dadb98039dbc58a70ad2c7c8a15
Author: dimich <dimich@chromium.org>
Date: Thu Oct 13 17:39:10 2016

Improve the page download:

- observe page loading in the current tab and captrue it when it is ready directly from the tab.
- if tab renavigates/closes, pass the request back to RequestCoordinator

BUG= 654955 

Review-Url: https://codereview.chromium.org/2412823002
Cr-Commit-Position: refs/heads/master@{#425077}

[modify] https://crrev.com/02d38c0b50c55dadb98039dbc58a70ad2c7c8a15/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
[modify] https://crrev.com/02d38c0b50c55dadb98039dbc58a70ad2c7c8a15/chrome/browser/android/offline_pages/recent_tab_helper.cc
[modify] https://crrev.com/02d38c0b50c55dadb98039dbc58a70ad2c7c8a15/chrome/browser/android/offline_pages/recent_tab_helper.h
[modify] https://crrev.com/02d38c0b50c55dadb98039dbc58a70ad2c7c8a15/chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc
[modify] https://crrev.com/02d38c0b50c55dadb98039dbc58a70ad2c7c8a15/components/offline_pages/background/request_coordinator.cc
[modify] https://crrev.com/02d38c0b50c55dadb98039dbc58a70ad2c7c8a15/components/offline_pages/background/request_coordinator_unittest.cc
[modify] https://crrev.com/02d38c0b50c55dadb98039dbc58a70ad2c7c8a15/components/offline_pages/offline_page_model.h
[modify] https://crrev.com/02d38c0b50c55dadb98039dbc58a70ad2c7c8a15/components/offline_pages/offline_page_model_impl.cc
[modify] https://crrev.com/02d38c0b50c55dadb98039dbc58a70ad2c7c8a15/components/offline_pages/offline_page_model_impl.h

Comment 2 by dim...@chromium.org, Oct 13 2016

Labels: Merge-Request-55

Comment 3 by dimu@chromium.org, Oct 13 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 14 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6afa7cf3c0dd8655dad4b40cb74abe3c3ba8078

commit e6afa7cf3c0dd8655dad4b40cb74abe3c3ba8078
Author: Dmitry Titov <dimich@chromium.org>
Date: Fri Oct 14 00:55:01 2016

Improve the page download:

- observe page loading in the current tab and captrue it when it is ready directly from the tab.
- if tab renavigates/closes, pass the request back to RequestCoordinator

BUG= 654955 

Review-Url: https://codereview.chromium.org/2412823002
Cr-Commit-Position: refs/heads/master@{#425077}
(cherry picked from commit 02d38c0b50c55dadb98039dbc58a70ad2c7c8a15)

Review URL: https://codereview.chromium.org/2420543004 .

Cr-Commit-Position: refs/branch-heads/2883@{#102}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/e6afa7cf3c0dd8655dad4b40cb74abe3c3ba8078/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
[modify] https://crrev.com/e6afa7cf3c0dd8655dad4b40cb74abe3c3ba8078/chrome/browser/android/offline_pages/recent_tab_helper.cc
[modify] https://crrev.com/e6afa7cf3c0dd8655dad4b40cb74abe3c3ba8078/chrome/browser/android/offline_pages/recent_tab_helper.h
[modify] https://crrev.com/e6afa7cf3c0dd8655dad4b40cb74abe3c3ba8078/chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc
[modify] https://crrev.com/e6afa7cf3c0dd8655dad4b40cb74abe3c3ba8078/components/offline_pages/background/request_coordinator.cc
[modify] https://crrev.com/e6afa7cf3c0dd8655dad4b40cb74abe3c3ba8078/components/offline_pages/background/request_coordinator_unittest.cc
[modify] https://crrev.com/e6afa7cf3c0dd8655dad4b40cb74abe3c3ba8078/components/offline_pages/offline_page_model.h
[modify] https://crrev.com/e6afa7cf3c0dd8655dad4b40cb74abe3c3ba8078/components/offline_pages/offline_page_model_impl.cc
[modify] https://crrev.com/e6afa7cf3c0dd8655dad4b40cb74abe3c3ba8078/components/offline_pages/offline_page_model_impl.h

Comment 5 by dim...@chromium.org, Oct 24 2016

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6afa7cf3c0dd8655dad4b40cb74abe3c3ba8078

commit e6afa7cf3c0dd8655dad4b40cb74abe3c3ba8078
Author: Dmitry Titov <dimich@chromium.org>
Date: Fri Oct 14 00:55:01 2016

Improve the page download:

- observe page loading in the current tab and captrue it when it is ready directly from the tab.
- if tab renavigates/closes, pass the request back to RequestCoordinator

BUG= 654955 

Review-Url: https://codereview.chromium.org/2412823002
Cr-Commit-Position: refs/heads/master@{#425077}
(cherry picked from commit 02d38c0b50c55dadb98039dbc58a70ad2c7c8a15)

Review URL: https://codereview.chromium.org/2420543004 .

Cr-Commit-Position: refs/branch-heads/2883@{#102}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/e6afa7cf3c0dd8655dad4b40cb74abe3c3ba8078/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
[modify] https://crrev.com/e6afa7cf3c0dd8655dad4b40cb74abe3c3ba8078/chrome/browser/android/offline_pages/recent_tab_helper.cc
[modify] https://crrev.com/e6afa7cf3c0dd8655dad4b40cb74abe3c3ba8078/chrome/browser/android/offline_pages/recent_tab_helper.h
[modify] https://crrev.com/e6afa7cf3c0dd8655dad4b40cb74abe3c3ba8078/chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc
[modify] https://crrev.com/e6afa7cf3c0dd8655dad4b40cb74abe3c3ba8078/components/offline_pages/background/request_coordinator.cc
[modify] https://crrev.com/e6afa7cf3c0dd8655dad4b40cb74abe3c3ba8078/components/offline_pages/background/request_coordinator_unittest.cc
[modify] https://crrev.com/e6afa7cf3c0dd8655dad4b40cb74abe3c3ba8078/components/offline_pages/offline_page_model.h
[modify] https://crrev.com/e6afa7cf3c0dd8655dad4b40cb74abe3c3ba8078/components/offline_pages/offline_page_model_impl.cc
[modify] https://crrev.com/e6afa7cf3c0dd8655dad4b40cb74abe3c3ba8078/components/offline_pages/offline_page_model_impl.h

Comment 7 by dimu@google.com, Nov 4 2016 

[Automated comment] removing mislabelled merge-merged-2840

Comment 8 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
►

Sign in to add a comment