New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 654949 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

nyan_big bvt: graphics_Sanity failure in _copyImageBlocklinear

Project Member Reported by h...@chromium.org, Oct 12 2016

Issue description

Filing a separate bug to track failures in nyan_freon blocklinear conversion path

Example https://00e9e64bac2f0c4ed3dcaef9c02b50e20fc4f7144956ed5c7c-apidata.googleusercontent.com/download/storage/v1/b/chromeos-autotest-results/o/80344509-chromeos-test%2Fchromeos4-row5-rack11-host5%2Fgraphics_Sanity%2Fdebug%2F

Ignore errors starting with "NvRm*" -- those are from NV closed source drivers.

Sample log #1:
10/11 01:39:08.486 ERROR|        base_utils:0280| [stderr] Traceback (most recent call last):
10/11 01:39:08.493 ERROR|        base_utils:0280| [stderr]   File "/usr/local/autotest/bin/screenshot.py", line 21, in <module>
10/11 01:39:08.505 ERROR|        base_utils:0280| [stderr]     image = crtcScreenshot(args.crtc)
10/11 01:39:08.514 ERROR|        base_utils:0280| [stderr]   File "/usr/local/autotest/cros/graphics/drm.py", line 455, in crtcScreenshot
10/11 01:39:08.521 ERROR|        base_utils:0280| [stderr]     pixels = _screenshot(_drm, image, framebuffer)
10/11 01:39:08.527 ERROR|        base_utils:0280| [stderr]   File "/usr/local/autotest/cros/graphics/drm.py", line 422, in _screenshot
10/11 01:39:08.534 ERROR|        base_utils:0280| [stderr]     _copyImageBlocklinear(image, fb, m, unformat)
10/11 01:39:08.541 ERROR|        base_utils:0280| [stderr]   File "/usr/local/autotest/cros/graphics/drm.py", line 392, in _copyImageBlocklinear
10/11 01:39:08.548 ERROR|        base_utils:0280| [stderr]     rgb = unformat(iterGob)
10/11 01:39:08.555 ERROR|        base_utils:0280| [stderr]   File "/usr/local/autotest/cros/graphics/drm.py", line 366, in _bgrx24
10/11 01:39:08.561 ERROR|        base_utils:0280| [stderr]     b = ord(next(i))
10/11 01:39:08.567 ERROR|        base_utils:0280| [stderr] StopIteration
10/11 01:39:12.229 ERROR|        base_utils:0280| [stderr] Traceback (most recent call last):
10/11 01:39:12.237 ERROR|        base_utils:0280| [stderr]   File "/usr/local/autotest/bin/screenshot.py", line 21, in <module>
10/11 01:39:12.248 ERROR|        base_utils:0280| [stderr]     image = crtcScreenshot(args.crtc)
10/11 01:39:12.256 ERROR|        base_utils:0280| [stderr]   File "/usr/local/autotest/cros/graphics/drm.py", line 455, in crtcScreenshot
10/11 01:39:12.261 ERROR|        base_utils:0280| [stderr]     pixels = _screenshot(_drm, image, framebuffer)
10/11 01:39:12.267 ERROR|        base_utils:0280| [stderr]   File "/usr/local/autotest/cros/graphics/drm.py", line 422, in _screenshot
10/11 01:39:12.273 ERROR|        base_utils:0280| [stderr]     _copyImageBlocklinear(image, fb, m, unformat)
10/11 01:39:12.279 ERROR|        base_utils:0280| [stderr]   File "/usr/local/autotest/cros/graphics/drm.py", line 392, in _copyImageBlocklinear
10/11 01:39:12.286 ERROR|        base_utils:0280| [stderr]     rgb = unformat(iterGob)
10/11 01:39:12.293 ERROR|        base_utils:0280| [stderr]   File "/usr/local/autotest/cros/graphics/drm.py", line 366, in _bgrx24
10/11 01:39:12.299 ERROR|        base_utils:0280| [stderr]     b = ord(next(i))
10/11 01:39:12.306 ERROR|        base_utils:0280| [stderr] StopIteration
10/11 01:39:13.275 DEBUG|        base_utils:0280| [stdout] # MAX_VIEWPORT_DIMS=(16384, 16384)


Sample log #2:
10/11 07:40:31.048 ERROR|        base_utils:0280| [stderr] Traceback (most recent call last):
10/11 07:40:31.056 ERROR|        base_utils:0280| [stderr]   File "/usr/local/autotest/bin/screenshot.py", line 21, in <module>
10/11 07:40:31.064 ERROR|        base_utils:0280| [stderr]     image = crtcScreenshot(args.crtc)
10/11 07:40:31.076 ERROR|        base_utils:0280| [stderr]   File "/usr/local/autotest/cros/graphics/drm.py", line 455, in crtcScreenshot
10/11 07:40:31.083 ERROR|        base_utils:0280| [stderr]     pixels = _screenshot(_drm, image, framebuffer)
10/11 07:40:31.091 ERROR|        base_utils:0280| [stderr]   File "/usr/local/autotest/cros/graphics/drm.py", line 422, in _screenshot
10/11 07:40:31.098 ERROR|        base_utils:0280| [stderr]     _copyImageBlocklinear(image, fb, m, unformat)
10/11 07:40:31.104 ERROR|        base_utils:0280| [stderr]   File "/usr/local/autotest/cros/graphics/drm.py", line 384, in _copyImageBlocklinear
10/11 07:40:31.110 ERROR|        base_utils:0280| [stderr]     m.seek(offset)
10/11 07:40:31.117 ERROR|        base_utils:0280| [stderr] ValueError: seek out of range
10/11 07:40:50.536 ERROR|        base_utils:0280| [stderr] Traceback (most recent call last):
10/11 07:40:50.543 ERROR|        base_utils:0280| [stderr]   File "/usr/local/autotest/bin/screenshot.py", line 21, in <module>
10/11 07:40:50.551 ERROR|        base_utils:0280| [stderr]     image = crtcScreenshot(args.crtc)
10/11 07:40:50.563 ERROR|        base_utils:0280| [stderr]   File "/usr/local/autotest/cros/graphics/drm.py", line 455, in crtcScreenshot
10/11 07:40:50.569 ERROR|        base_utils:0280| [stderr]     pixels = _screenshot(_drm, image, framebuffer)
10/11 07:40:50.576 ERROR|        base_utils:0280| [stderr]   File "/usr/local/autotest/cros/graphics/drm.py", line 422, in _screenshot
10/11 07:40:50.583 ERROR|        base_utils:0280| [stderr]     _copyImageBlocklinear(image, fb, m, unformat)
10/11 07:40:50.588 ERROR|        base_utils:0280| [stderr]   File "/usr/local/autotest/cros/graphics/drm.py", line 384, in _copyImageBlocklinear
10/11 07:40:50.594 ERROR|        base_utils:0280| [stderr]     m.seek(offset)
10/11 07:40:50.600 ERROR|        base_utils:0280| [stderr] ValueError: seek out of range
10/11 07:40:51.870 ERROR|        base_utils:0280| [stderr] convert: UnableToOpenBlob `/usr/local/autotest/results/default/graphics_Sanity/results/screenshot1_generated.png': No such file or directory @ error/blob.c/OpenBlob/2642.
10/11 07:40:51.878 ERROR|        base_utils:0280| [stderr] convert: UnableToOpenFile `/usr/local/autotest/results/default/graphics_Sanity/results/screenshot1_generated.png' @ error/png.c/ReadPNGImage/3733.
10/11 07:40:51.884 ERROR|        base_utils:0280| [stderr] convert: NoImagesDefined `/usr/local/autotest/results/default/graphics_Sanity/results/screenshot1_generated_resized.png' @ error/convert.c/ConvertImageCommand/3044.
 

Comment 1 by h...@chromium.org, Oct 12 2016

On tot (branch 56) we're also seeing this on nyan_big and nyan_kitty as of 8887 (the first time we've enabled freon on kitty and blaze)

However blaze 8888 build seem to pass the test just fine (https://wmatrix.googleplex.com/testrun/unfiltered?test_ids=361697851)

Comment 2 by h...@chromium.org, Oct 12 2016

Status: Started (was: Assigned)
Ok I locked chromeos4-row5-rack11-host5 and took a look.

It seems that my nyan_big has a 1366x768 panel, while the DUT in the lab has a 1920x1080 panel.

Comment 3 by h...@chromium.org, Oct 12 2016

Patch uploaded to https://chromium-review.googlesource.com/#/c/396920/

The host (chromeos4-row5-rack11-host5) is unlocked.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d0762edbad798a5203df727ddb9eab2d24fdc860

commit d0762edbad798a5203df727ddb9eab2d24fdc860
Author: Haixia Shi <hshi@chromium.org>
Date: Wed Oct 12 01:10:00 2016

graphics_utils: add mmap size padding for tegra

On tegra the mmap size need to be padded in both X and Y directions to
align with GOB boundaries.

Also remove the redundant "pixels" variable which is never used.

BUG= chromium:654949 
TEST=test_that graphics_Sanity on nyan_big with 1920x1080 panel

Change-Id: I3084d5b8e64465ea57ee3b032feb94fc69ff7421
Reviewed-on: https://chromium-review.googlesource.com/396920
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Haixia Shi <hshi@chromium.org>
Commit-Queue: Haixia Shi <hshi@chromium.org>
Trybot-Ready: Haixia Shi <hshi@chromium.org>

[modify] https://crrev.com/d0762edbad798a5203df727ddb9eab2d24fdc860/client/cros/graphics/drm.py

Comment 5 by h...@chromium.org, Oct 12 2016

Labels: Merge-Request-55
Need this patch (#4) in branch 55 too. Thanks.

Comment 6 by dimu@chromium.org, Oct 12 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 12 2016

Labels: merge-merged-release-R55-8872.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5d53e8974a947274b0e1adf6cc607b379d4b1265

commit 5d53e8974a947274b0e1adf6cc607b379d4b1265
Author: Haixia Shi <hshi@chromium.org>
Date: Wed Oct 12 01:10:00 2016

graphics_utils: add mmap size padding for tegra

On tegra the mmap size need to be padded in both X and Y directions to
align with GOB boundaries.

Also remove the redundant "pixels" variable which is never used.

BUG= chromium:654949 
TEST=test_that graphics_Sanity on nyan_big with 1920x1080 panel

Change-Id: I3084d5b8e64465ea57ee3b032feb94fc69ff7421
Reviewed-on: https://chromium-review.googlesource.com/396920
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Haixia Shi <hshi@chromium.org>
Commit-Queue: Haixia Shi <hshi@chromium.org>
Trybot-Ready: Haixia Shi <hshi@chromium.org>
(cherry picked from commit d0762edbad798a5203df727ddb9eab2d24fdc860)
Reviewed-on: https://chromium-review.googlesource.com/396490
Reviewed-by: Haixia Shi <hshi@chromium.org>

[modify] https://crrev.com/5d53e8974a947274b0e1adf6cc607b379d4b1265/client/cros/graphics/drm.py

Comment 8 by h...@chromium.org, Oct 12 2016

Status: Fixed (was: Started)

Comment 9 by h...@chromium.org, Oct 12 2016

Issue 655246 has been merged into this issue.
Project Member

Comment 10 by sheriffbot@chromium.org, Oct 15 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 11 by h...@chromium.org, Oct 16 2016

Labels: -Merge-Approved-55

Sign in to add a comment