New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 654947 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Chromium test launcher has hardcoded test timeout (45 seconds)

Project Member Reported by xyzzyz@chromium.org, Oct 12 2016

Issue description

Chromium test launcher checks if test took less than TestTimeouts::test_launcher_timeout(), and reports a timeout even if the test was a success[1].

There's a test in ipc_tests, IPCSyncChannelTest.ChattyServer that takes over 25 seconds on my developer machine. However, we also run the test as part of our CI workflow in more resource constrained environment, where it sometimes hit the 45 seconds mark, eg. 

[       OK ] IPCSyncChannelTest.ChattyServer (45567 ms)

This results in flakiness. 

It would be nice if the per test timeout was configurable somehow, maybe as a flag for the launcher.


[1] - https://cs.chromium.org/chromium/src/base/test/launcher/unit_test_launcher.cc?sq=package:chromium&dr=C&rcl=1476213403&l=312
 
Cc: phajdan@google.com
Owner: phajdan.jr@chromium.org
Status: WontFix (was: Untriaged)
It's not hardcoded, but controlled by --test-launcher-timeout flag. Please see base/test/test_timeouts.cc :

  // Test launcher timeout is independent from anything above action timeout.
  InitializeTimeout(switches::kTestLauncherTimeout, action_timeout_ms_,
                    &test_launcher_timeout_ms_);

Sign in to add a comment