Alan is working on slides/instructions to move the cookies and local browsing data from the dialog to a subpage.
Alan, please add a link (to the instructions) and make me the owner of this bug when you're ready.
Edits deck: https://docs.google.com/presentation/d/1AAF6Z-HW81I-JCuGDU1aaj4c_XXAbDuMlYPN8s4cmfc/edit#slide=id.g1560180312_0_0 mocks for subpage: https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-Privacy_02.png%3Fz=width Specs https://docs.google.com/presentation/d/1AAF6Z-HW81I-JCuGDU1aaj4c_XXAbDuMlYPN8s4cmfc/edit#slide=id.g179eba34d4_0_198
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc04c3ad2ead66463a7a296f77d3c9bd9f8794da commit bc04c3ad2ead66463a7a296f77d3c9bd9f8794da Author: dschuyler <dschuyler@chromium.org> Date: Fri Oct 28 19:47:22 2016 [MD settings] move cookie tree management to cookie tree behavior This CL moves code that will soon be shared between the site_data page and the site_data_details_subpage page. This is separated away from adding the subpage to ease the review process and support git bisect, if needed in the future. The code to load and manage the cookie tree has been moved into cookie_tree_behavior. The code to fill out the cookie info has been moved to cookie_info. Support for closure compilation in content settings has been improved (some types were incorrect). This CL is related groundwork for a future CL and not a full fix for the bug. BUG= 654943 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2451553008 Cr-Commit-Position: refs/heads/master@{#428465} [modify] https://crrev.com/bc04c3ad2ead66463a7a296f77d3c9bd9f8794da/chrome/browser/resources/settings/settings_resources.grd [modify] https://crrev.com/bc04c3ad2ead66463a7a296f77d3c9bd9f8794da/chrome/browser/resources/settings/site_settings/compiled_resources2.gyp [modify] https://crrev.com/bc04c3ad2ead66463a7a296f77d3c9bd9f8794da/chrome/browser/resources/settings/site_settings/cookie_info.js [add] https://crrev.com/bc04c3ad2ead66463a7a296f77d3c9bd9f8794da/chrome/browser/resources/settings/site_settings/cookie_tree_behavior.html [add] https://crrev.com/bc04c3ad2ead66463a7a296f77d3c9bd9f8794da/chrome/browser/resources/settings/site_settings/cookie_tree_behavior.js [modify] https://crrev.com/bc04c3ad2ead66463a7a296f77d3c9bd9f8794da/chrome/browser/resources/settings/site_settings/cookie_tree_node.js [modify] https://crrev.com/bc04c3ad2ead66463a7a296f77d3c9bd9f8794da/chrome/browser/resources/settings/site_settings/site_data.html [modify] https://crrev.com/bc04c3ad2ead66463a7a296f77d3c9bd9f8794da/chrome/browser/resources/settings/site_settings/site_data.js [modify] https://crrev.com/bc04c3ad2ead66463a7a296f77d3c9bd9f8794da/chrome/browser/resources/settings/site_settings/site_data_details_dialog.js [modify] https://crrev.com/bc04c3ad2ead66463a7a296f77d3c9bd9f8794da/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f58402502d291872de78265747751f4728b9e36 commit 0f58402502d291872de78265747751f4728b9e36 Author: dschuyler <dschuyler@chromium.org> Date: Wed Nov 02 20:44:46 2016 [MD settings] cookie and site data from dialog to subpage This CL moves the cookie data details from a dialog into a settings subpage. BUG= 654943 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2450423002 Cr-Commit-Position: refs/heads/master@{#429392} [modify] https://crrev.com/0f58402502d291872de78265747751f4728b9e36/chrome/app/settings_strings.grdp [modify] https://crrev.com/0f58402502d291872de78265747751f4728b9e36/chrome/browser/resources/settings/privacy_page/compiled_resources2.gyp [modify] https://crrev.com/0f58402502d291872de78265747751f4728b9e36/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/0f58402502d291872de78265747751f4728b9e36/chrome/browser/resources/settings/privacy_page/privacy_page.js [modify] https://crrev.com/0f58402502d291872de78265747751f4728b9e36/chrome/browser/resources/settings/route.js [modify] https://crrev.com/0f58402502d291872de78265747751f4728b9e36/chrome/browser/resources/settings/settings_resources.grd [modify] https://crrev.com/0f58402502d291872de78265747751f4728b9e36/chrome/browser/resources/settings/site_settings/compiled_resources2.gyp [modify] https://crrev.com/0f58402502d291872de78265747751f4728b9e36/chrome/browser/resources/settings/site_settings/cookie_tree_behavior.js [modify] https://crrev.com/0f58402502d291872de78265747751f4728b9e36/chrome/browser/resources/settings/site_settings/cookie_tree_node.js [modify] https://crrev.com/0f58402502d291872de78265747751f4728b9e36/chrome/browser/resources/settings/site_settings/site_data.html [modify] https://crrev.com/0f58402502d291872de78265747751f4728b9e36/chrome/browser/resources/settings/site_settings/site_data.js [delete] https://crrev.com/da97a9ff8dbe3c463ff7d64fd765483401e2feb2/chrome/browser/resources/settings/site_settings/site_data_details_dialog.html [delete] https://crrev.com/da97a9ff8dbe3c463ff7d64fd765483401e2feb2/chrome/browser/resources/settings/site_settings/site_data_details_dialog.js [add] https://crrev.com/0f58402502d291872de78265747751f4728b9e36/chrome/browser/resources/settings/site_settings/site_data_details_subpage.html [add] https://crrev.com/0f58402502d291872de78265747751f4728b9e36/chrome/browser/resources/settings/site_settings/site_data_details_subpage.js [modify] https://crrev.com/0f58402502d291872de78265747751f4728b9e36/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e02d9849ea6b00cd15136ee2daba55b5466cf43b commit e02d9849ea6b00cd15136ee2daba55b5466cf43b Author: dschuyler <dschuyler@chromium.org> Date: Wed Nov 02 23:13:25 2016 [MD settings] collapse cookie details in subpage This CL adds collapsing areas for the cookie details in the cookie settings subpage. BUG= 654943 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2457633002 Cr-Commit-Position: refs/heads/master@{#429443} [modify] https://crrev.com/e02d9849ea6b00cd15136ee2daba55b5466cf43b/chrome/browser/resources/settings/site_settings/cookie_tree_node.js [modify] https://crrev.com/e02d9849ea6b00cd15136ee2daba55b5466cf43b/chrome/browser/resources/settings/site_settings/site_data_details_subpage.html [modify] https://crrev.com/e02d9849ea6b00cd15136ee2daba55b5466cf43b/chrome/browser/resources/settings/site_settings/site_data_details_subpage.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd2b8502f06ffc672fe4465a8d2863b4dd38108d commit cd2b8502f06ffc672fe4465a8d2863b4dd38108d Author: dschuyler <dschuyler@chromium.org> Date: Wed Nov 02 23:45:22 2016 [MD settings] site data details subpage title This CL changes the title of the cookies data details subpage to add a note about it being local data. BUG= 654943 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2457643002 Cr-Commit-Position: refs/heads/master@{#429459} [modify] https://crrev.com/cd2b8502f06ffc672fe4465a8d2863b4dd38108d/chrome/app/settings_strings.grdp [modify] https://crrev.com/cd2b8502f06ffc672fe4465a8d2863b4dd38108d/chrome/browser/resources/settings/site_settings/site_data_details_subpage.js [modify] https://crrev.com/cd2b8502f06ffc672fe4465a8d2863b4dd38108d/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
Comment 1 by dschuyler@chromium.org
, Oct 12 2016