re: (3), MIME type handling is not implemented yet, but should be in a future update

re: (5), domain level intent filtering should work.  Yusuke, any ideas?

Re: 3), although Chrome does not support intent filters with android:mimeType yet, Files app (Chrome OS' default filer app) does. For now, you can work around the issue by downloading the pdf, then right-clicking the pdf file in Files app. If you right-click the file in the app (and then clicks "more actions"), you'll see your app's name in the context menu. Just FYI.

I'm taking a look at 5).

comment #3: this is about Chrome-to-ARC intent handling, not the other way around which hashimoto@ is working on.

re#4, (I was almost going to add that (3) is being addressed but I stopped realizing this was something else, oh well)

Re 5), this is WAI at this point. Chrome does not show the chooser for https-to-http navigations. I've filed an internal bug (Elijah: b/32124395) to see if there's a way to improve it.

Let me keep this bug open for now.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21236422b54f032ac6a7dcd42d4c8768129f82ae

commit 21236422b54f032ac6a7dcd42d4c8768129f82ae
Author: djacobo <djacobo@google.com>
Date: Thu Oct 20 21:49:12 2016

Capture http to https navigations w/ intent picker

For navigations from http to https we cannot rely on the Referrer's url
since it is cleaned due to the sanitization proccess. For this case we
will make use of GetLastCommittedURL(), the main purpose of this
information is to decide whether or not to register
ArcNavigationThrottle as a candidate to handle a given navigation.

BUG= 654941 
TEST=look at the bug description for repro.

Review-Url: https://chromiumcodereview.appspot.com/2436923002
Cr-Commit-Position: refs/heads/master@{#426610}

[modify] https://crrev.com/21236422b54f032ac6a7dcd42d4c8768129f82ae/chrome/browser/chromeos/arc/arc_navigation_throttle.cc

+bhthompson@

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10e9dc3198f60a958c62d67062724ca81d9228d3

commit 10e9dc3198f60a958c62d67062724ca81d9228d3
Author: Yusuke Sato <yusukes@google.com>
Date: Fri Oct 21 23:05:00 2016

Capture http to https navigations w/ intent picker

For navigations from http to https we cannot rely on the Referrer's url
since it is cleaned due to the sanitization proccess. For this case we
will make use of GetLastCommittedURL(), the main purpose of this
information is to decide whether or not to register
ArcNavigationThrottle as a candidate to handle a given navigation.

BUG= 654941 
TEST=look at the bug description for repro.

Review-Url: https://chromiumcodereview.appspot.com/2436923002
Cr-Commit-Position: refs/heads/master@{#426610}
(cherry picked from commit 21236422b54f032ac6a7dcd42d4c8768129f82ae)

Review URL: https://codereview.chromium.org/2445493002 .

Cr-Commit-Position: refs/branch-heads/2883@{#233}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/10e9dc3198f60a958c62d67062724ca81d9228d3/chrome/browser/chromeos/arc/arc_navigation_throttle.cc

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

let's not merge this to 52 :)

My bad, the autocomplete goes to 52 by default :)

Your change meets the bar and is auto-approved for M55 (branch: 2883)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10e9dc3198f60a958c62d67062724ca81d9228d3

commit 10e9dc3198f60a958c62d67062724ca81d9228d3
Author: Yusuke Sato <yusukes@google.com>
Date: Fri Oct 21 23:05:00 2016

Capture http to https navigations w/ intent picker

For navigations from http to https we cannot rely on the Referrer's url
since it is cleaned due to the sanitization proccess. For this case we
will make use of GetLastCommittedURL(), the main purpose of this
information is to decide whether or not to register
ArcNavigationThrottle as a candidate to handle a given navigation.

BUG= 654941 
TEST=look at the bug description for repro.

Review-Url: https://chromiumcodereview.appspot.com/2436923002
Cr-Commit-Position: refs/heads/master@{#426610}
(cherry picked from commit 21236422b54f032ac6a7dcd42d4c8768129f82ae)

Review URL: https://codereview.chromium.org/2445493002 .

Cr-Commit-Position: refs/branch-heads/2883@{#233}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/10e9dc3198f60a958c62d67062724ca81d9228d3/chrome/browser/chromeos/arc/arc_navigation_throttle.cc

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04a713e72e35274ba7e3f219dbc60c670208b120

commit 04a713e72e35274ba7e3f219dbc60c670208b120
Author: djacobo <djacobo@google.com>
Date: Mon Oct 31 23:58:26 2016

Modifies how Arc's throttle handles redirections

Since we want to handle navigations going from https to http we need to
enforce having a Referrer(), we call it |starting_gurl_|. This will
allow us to know where the navigation started and fire up the intent
picker.

This also modifies the way we treat redirections within the same
navigation throttle object. Since we now enforce having a starting GURL
we are not discarding as many throttles via ShouldOverrideUrlLoading(),
which previously discarded a throttle just because it didn't contain a
referrer.

BUG= 654941 
TEST=Check the repro info on the bug, also manually tested with
youtube links.

Review-Url: https://codereview.chromium.org/2458073003
Cr-Commit-Position: refs/heads/master@{#428873}

[modify] https://crrev.com/04a713e72e35274ba7e3f219dbc60c670208b120/chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.cc
[modify] https://crrev.com/04a713e72e35274ba7e3f219dbc60c670208b120/chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.h
[modify] https://crrev.com/04a713e72e35274ba7e3f219dbc60c670208b120/chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle_unittest.cc

Your change meets the bar and is auto-approved for M55 (branch: 2883)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/827d3e0f0234f4fdec8dfc47cdf4fbc6a3b3346d

commit 827d3e0f0234f4fdec8dfc47cdf4fbc6a3b3346d
Author: Yusuke Sato <yusukes@google.com>
Date: Thu Nov 03 20:42:24 2016

Modifies how Arc's throttle handles redirections

Since we want to handle navigations going from https to http we need to
enforce having a Referrer(), we call it |starting_gurl_|. This will
allow us to know where the navigation started and fire up the intent
picker.

This also modifies the way we treat redirections within the same
navigation throttle object. Since we now enforce having a starting GURL
we are not discarding as many throttles via ShouldOverrideUrlLoading(),
which previously discarded a throttle just because it didn't contain a
referrer.

BUG= 654941 
TEST=Check the repro info on the bug, also manually tested with
youtube link

R=yusukes@chromium.org

Review URL: https://codereview.chromium.org/2471783005 .

Cr-Commit-Position: refs/branch-heads/2883@{#444}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/827d3e0f0234f4fdec8dfc47cdf4fbc6a3b3346d/chrome/browser/chromeos/arc/arc_navigation_throttle.cc
[modify] https://crrev.com/827d3e0f0234f4fdec8dfc47cdf4fbc6a3b3346d/chrome/browser/chromeos/arc/arc_navigation_throttle.h
[modify] https://crrev.com/827d3e0f0234f4fdec8dfc47cdf4fbc6a3b3346d/chrome/browser/chromeos/arc/arc_navigation_throttle_unittest.cc

[Automated comment] removing mislabelled merge-merged-2840

[Automated comment] removing mislabelled merge-merged-2840