New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 654940 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 614588



Sign in to add a comment

Make the title content settings until site settings is enabled

Project Member Reported by dschuyler@chromium.org, Oct 11 2016

Issue description

In chrome://md-settings/siteSettings
title feature as Content settings.
 
Blocking: 614588

Comment 2 by dbeam@chromium.org, Oct 17 2016

Components: UI>Settings

Comment 3 by dbeam@chromium.org, Oct 18 2016

Status: Started (was: Assigned)
https://codereview.chromium.org/2422233004/
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5b4ee3f84b2765fc91ef58fb14af3384cafe729

commit c5b4ee3f84b2765fc91ef58fb14af3384cafe729
Author: dschuyler <dschuyler@chromium.org>
Date: Tue Oct 18 18:54:41 2016

[MD settings] name Content settings separately from site settings

This CL puts the 'site settings' name behind the enable-site-settings
flag. When site settings is disabled, the name 'content settings' is
used.

BUG= 654940 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://chromiumcodereview.appspot.com/2422233004
Cr-Commit-Position: refs/heads/master@{#426013}

[modify] https://crrev.com/c5b4ee3f84b2765fc91ef58fb14af3384cafe729/chrome/app/settings_strings.grdp
[modify] https://crrev.com/c5b4ee3f84b2765fc91ef58fb14af3384cafe729/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/c5b4ee3f84b2765fc91ef58fb14af3384cafe729/chrome/browser/resources/settings/privacy_page/privacy_page.js
[modify] https://crrev.com/c5b4ee3f84b2765fc91ef58fb14af3384cafe729/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Status: Fixed (was: Started)

Sign in to add a comment