"Accept connection" prompt for IT2Me appears behind the Chrome window |
||||||||||
Issue descriptionVersion: 55.0.2883.6 OS: Windows 7 What steps will reproduce the problem? (1) Open CRD (I did it inside a curtained Me2Me session--not sure if that's important). (2) Expand the Remote Assistance section and click Share. (3) On another computer enter the access code and click Access. What is the expected output? The sharing computer should get a dialog prompt to accept the connection. What do you see instead? The prompt appears, but is behind the Chrome window. The only indication is a flashing icon on the task bar which must first be clicked before the connection can be accepted.
,
Oct 12 2016
,
Oct 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37d4966ef8a8e5cc5b83d7892f1622f679529d93 commit 37d4966ef8a8e5cc5b83d7892f1622f679529d93 Author: joedow <joedow@chromium.org> Date: Wed Oct 12 22:30:28 2016 Adding 'Always on top' behavior to the It2Me Confirmation Dialog This CL sets a flag on the It2MeConfirmationDialog created on Windows which causes it to be displayed as a top-level window. I've also added a call to ensure the dialog is above any other top-level window. These two changes will ensure the dialog is displayed over the other windows on the desktop, regardless of whethet they are topmost windows or not. BUG= 654938 Review-Url: https://codereview.chromium.org/2418613003 Cr-Commit-Position: refs/heads/master@{#424883} [modify] https://crrev.com/37d4966ef8a8e5cc5b83d7892f1622f679529d93/remoting/host/it2me/it2me_confirmation_dialog_win.cc
,
Oct 12 2016
This change is specific to Chrome Remote Desktop (does not affect the browser), will request permission to merge into M55 release branch.
,
Oct 13 2016
,
Oct 13 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6d9de9917174149fe5ad52188105b4f99a973ff commit a6d9de9917174149fe5ad52188105b4f99a973ff Author: Joe Downing <joedow@google.com> Date: Thu Oct 13 21:47:50 2016 Adding 'Always on top' behavior to the It2Me Confirmation Dialog This CL sets a flag on the It2MeConfirmationDialog created on Windows which causes it to be displayed as a top-level window. I've also added a call to ensure the dialog is above any other top-level window. These two changes will ensure the dialog is displayed over the other windows on the desktop, regardless of whethet they are topmost windows or not. BUG= 654938 Review-Url: https://codereview.chromium.org/2418613003 Cr-Commit-Position: refs/heads/master@{#424883} (cherry picked from commit 37d4966ef8a8e5cc5b83d7892f1622f679529d93) Review URL: https://codereview.chromium.org/2415233002 . Cr-Commit-Position: refs/branch-heads/2883@{#96} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/a6d9de9917174149fe5ad52188105b4f99a973ff/remoting/host/it2me/it2me_confirmation_dialog_win.cc
,
Oct 13 2016
Fix has been merged into M55 release branch. Resolving as fixed and assigning for verification.
,
Oct 19 2016
erified Fixed in QA release 55.0.2883.17.
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6d9de9917174149fe5ad52188105b4f99a973ff commit a6d9de9917174149fe5ad52188105b4f99a973ff Author: Joe Downing <joedow@google.com> Date: Thu Oct 13 21:47:50 2016 Adding 'Always on top' behavior to the It2Me Confirmation Dialog This CL sets a flag on the It2MeConfirmationDialog created on Windows which causes it to be displayed as a top-level window. I've also added a call to ensure the dialog is above any other top-level window. These two changes will ensure the dialog is displayed over the other windows on the desktop, regardless of whethet they are topmost windows or not. BUG= 654938 Review-Url: https://codereview.chromium.org/2418613003 Cr-Commit-Position: refs/heads/master@{#424883} (cherry picked from commit 37d4966ef8a8e5cc5b83d7892f1622f679529d93) Review URL: https://codereview.chromium.org/2415233002 . Cr-Commit-Position: refs/branch-heads/2883@{#96} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/a6d9de9917174149fe5ad52188105b4f99a973ff/remoting/host/it2me/it2me_confirmation_dialog_win.cc
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Feb 15 2017
This was released in M55, updating label. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by joedow@chromium.org
, Oct 12 2016Owner: joedow@chromium.org
Status: Assigned (was: Untriaged)