New issue
Advanced search Search tips

Issue 654927 link

Starred by 1 user
Status: Verified
Owner:
hbos@chromium.org
Closed: Oct 2016
Cc:
hta@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 627816
issue 633550



Sign in to add a comment

RTCPeerConnection.getStats: RTCDataChannelStats

Project Member Reported by hbos@chromium.org, Oct 11 2016 
Add RTCDataChannelStats and all of its members.
https://w3c.github.io/webrtc-stats/#dcstats-dict*

dictionary RTCDataChannelStats : RTCStats {
    DOMString           label;
    DOMString           protocol;
    long                datachannelid;
    RTCDataChannelState state;
    unsigned long       messagesSent;
    unsigned long long  bytesSent;
    unsigned long       messagesReceived;
    unsigned long long  bytesReceived;
};

Comment 1 by hbos@chromium.org, Oct 12 2016

Blocking: 627816
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/75c8fb4b2c138b99f6bb7ffa6e2f415594116eed

commit 75c8fb4b2c138b99f6bb7ffa6e2f415594116eed
Author: hbos <hbos@webrtc.org>
Date: Wed Oct 12 21:48:15 2016

DataChannelInterface default impl of [messages/bytes]_[sent/received].

The default implementations are provided as to not break Chromium mocks,
as soon as we have done a successful roll they should be updated and the
default implementations removed.

TBR=hta@webrtc.org, deadbeef@webrtc.org
NOTRY=True
BUG= chromium:654927 

Review-Url: https://codereview.webrtc.org/2414613003
Cr-Commit-Position: refs/heads/master@{#14617}

[modify] https://crrev.com/75c8fb4b2c138b99f6bb7ffa6e2f415594116eed/webrtc/api/datachannelinterface.h

Comment 5 by hbos@chromium.org, Oct 19 2016

Status: Verified (was: Started)

Comment 6 by anatolid@chromium.org, Nov 15 2016 

[bulk-edit : please ignore if not applicable]

Could you please set the correct milestone for this issue?

Comment 7 by hbos@chromium.org, Nov 16 2016

Labels: M-56
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93aae6e1386ac18f2859aaa4a8558946fbd6cc39

commit 93aae6e1386ac18f2859aaa4a8558946fbd6cc39
Author: hbos <hbos@chromium.org>
Date: Wed Nov 23 20:54:20 2016

MockDataChannelImpl: Implement new interface methods as NOTIMPLEMENTED()

See https://cs.chromium.org/chromium/src/third_party/webrtc/api/datachannelinterface.h?q=datachannelinterface.h&sq=package:chromium&dr=CSs&l=128

This mock does not need them.
This allows us to remove the dummy default implementation of these
methods in the webrtc repo.

BUG= 654927 

Review-Url: https://codereview.chromium.org/2520033005
Cr-Commit-Position: refs/heads/master@{#434244}

[modify] https://crrev.com/93aae6e1386ac18f2859aaa4a8558946fbd6cc39/content/renderer/media/mock_data_channel_impl.cc
[modify] https://crrev.com/93aae6e1386ac18f2859aaa4a8558946fbd6cc39/content/renderer/media/mock_data_channel_impl.h
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/c42d37646f8e28a54e628cc68c6c3c3c0bfa68f4

commit c42d37646f8e28a54e628cc68c6c3c3c0bfa68f4
Author: hbos <hbos@webrtc.org>
Date: Thu Nov 24 09:17:52 2016

DataChannelInterface: Remove default implementation of methods.

This can land as soon as https://codereview.chromium.org/2520033005/ has
landed.

BUG= chromium:654927 

Review-Url: https://codereview.webrtc.org/2524033002
Cr-Commit-Position: refs/heads/master@{#15221}

[modify] https://crrev.com/c42d37646f8e28a54e628cc68c6c3c3c0bfa68f4/webrtc/api/datachannelinterface.h
►

Sign in to add a comment