Deduplicate autofill and password_manager factory code and test it |
||||||||
Issue descriptioncontent_password_manager_driver_factory.cc, content_autofill_driver_factory.cc, and (soon) password_visibility_service_factory.cc all share a lot of code, and it's not really tested. This code could be de-duplicated in a base class, with tests. (See https://codereview.chromium.org/2378503002/diff/180001/components/password_manager/content/browser/password_visibility_service_factory.h#newcode1)
,
Oct 12 2016
Thanks vabr! I'm marking as Available in case anyone wants to do this before I get to it. Note that password_visibility_service_factory.cc does not in fact exist because it turns out we didn't need it.
,
Oct 12 2016
,
Oct 13 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 16 2017
,
May 1 2018
,
May 7 2018
,
Nov 29
vabr going hobby only -> reducing involvement. Please contact me directly in urgent matters. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by vabr@chromium.org
, Oct 12 2016