New issue
Advanced search Search tips

Issue 654898 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android
Pri: 3
Type: Bug



Sign in to add a comment

Support UseZoomForDSF for the blimp platform.

Project Member Reported by khushals...@chromium.org, Oct 11 2016

Issue description

With UseZoomForDSF enabled, the device scale factor given to blink and cc remains the default scale factor, while WebView::setZoomFactorForDeviceScaleFactor is used to scale the page contents when the device scale factor changes.

Since the same device scale factor gets propagated to the client, this is problematic since the compositor input handling still relies on the device scale factor being accurate.
 

Comment 1 by osh...@chromium.org, Oct 11 2016

Can you be more specific about the issue? What did you mean by "client" in this context?

Comment 2 by w...@chromium.org, Oct 11 2016

Components: Mobile>Blimp
Ah, sorry. I meant the blimp client. We enable this mode in the content layer on the engine side using switches::kUseRemoteCompositing. With this mode when the renderer is started, the complete cc::LayerTreeHost state is serialized on the engine (service) side and and sent to an android client, where it is consumed by the compositor to produce the final output.

This means that impl thread input handling, or basically what is done here, https://cs.chromium.org/chromium/src/ui/events/blink/input_handler_proxy.h, is being done on a compositor running on android device.

Since the device scale factor used by the compositor is what it received from the engine in the serialized LayerTree state, it ends up being incorrect for fling and pinch-zoom gestures handled on the compositor on the android client.

Comment 4 by osh...@chromium.org, Oct 13 2016

As we discussed offline, if you mixed android client & linux renderer without proper plumbing/settings, it won't work.

On the platform that is properly handled, these things should work. (for ex, 
pinch-to-zoom/gestures stuff are working on ChromeOS)


Sure, that makes sense. I just wanted to document that before this setting is enabled by default for all platforms, we have to make sure that it works for blimp as well.

Is there a meta-bug tracking the use-browser-zoom-for-dsf work? Perhaps I can mark this as blocking that bug so it doesn't slip by.

Comment 6 by w...@chromium.org, Nov 15 2016

Components: -Mobile>Blimp Mobile>Blimp>Client Mobile>Blimp>Engine
Labels: OS-Android OS-Linux
Owner: khushals...@chromium.org
Status: Assigned (was: Untriaged)
Khushal, can you adjust priority and add milestone if necessary?
Summary: Support UseZoomForDSF for the blimp platform. (was: Device Scale Factor reported to the client is incorrect.)
The original bug isn't there anymore, and this isn't really required for blimp. The bug was just meant to be added to ensure that the UseZoomForDSF work doesn't end up forgetting about blimp.

oshima@, Could you point me to a bug for what I mentioned in #5, so I can make sure this one gets tracked there too?
Status: WontFix (was: Assigned)
Obsolete, WontFix.
Labels: Archive-Blimp

Sign in to add a comment