New issue
Advanced search Search tips

Issue 654894 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

License checker code blows up on invalid characters

Project Member Reported by zentaro@chromium.org, Oct 11 2016

Issue description


In trying to cross-compile app-crypt/mit-krb5. The license checker tries to read a windows rtf file and complains about invalid characters. 

Error below....

 File "/mnt/host/source/chromite/licensing/ebuild_license_hook", line 168, in <module>
    DoMain()
  File "/mnt/host/source/chromite/licensing/ebuild_license_hook", line 164, in DoMain
    commandline.ScriptWrapperMain(FindTarget)
  File "/mnt/host/source/chromite/lib/commandline.py", line 834, in ScriptWrapperMain
    ret = target(argv[1:])
  File "/mnt/host/source/chromite/licensing/ebuild_license_hook.py", line 26, in main
    licenses_lib.HookPackageProcess(opts.builddir)
  File "/mnt/host/source/chromite/licensing/licenses_lib.py", line 1208, in HookPackageProcess
    pkg.GetLicenses(build_info_dir, src_dir)
  File "/mnt/host/source/chromite/licensing/licenses_lib.py", line 750, in GetLicenses
    self._ExtractLicenses(src_dir, need_copyright_attribution)
  File "/mnt/host/source/chromite/licensing/licenses_lib.py", line 525, in _ExtractLicenses
    license_txt = ReadUnknownEncodedFile(license_path, 'Adding License')
  File "/mnt/host/source/chromite/licensing/licenses_lib.py", line 1157, in ReadUnknownEncodedFile
    (char_list, file_path))
ValueError: Illegal XML characters [u'\x00'] found in /build/samus/tmp/portage/app-crypt/mit-krb5-1.9.2-r2/work/krb5-1.9.2/src/windows/installer/nsis/licenses.rtf.
 
Components: -Infra Infra>Client>ChromeOS
Labels: current-issue

Comment 2 by autumn@chromium.org, Oct 11 2016

Labels: -current-issue

Comment 3 by vapier@chromium.org, Nov 22 2016

Labels: -Restrict-View-Google -Pri-1 Pri-2
Blocking: -654842
Labels: Hotlist-Fixit
Owner: ----
Owner: dgarr...@chromium.org
Status: Started (was: Untriaged)
Labels: cros-infra-fixedit-q117
Status: Fixed (was: Started)

Comment 9 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 10 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 12 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment