New issue
Advanced search Search tips

Issue 654893 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Add a link to logdog unified logs from CrOS builds

Project Member Reported by pprabhu@chromium.org, Oct 11 2016

Issue description

logdog streams for the different steps of a build can be unified via a wildchar url, but there is no link from the waterfall build to such a unified view.
We should add one for ease of use.

Eg:
Build: https://uberchromegw.corp.google.com/i/chromeos/builders/cyan-paladin/builds/609
buildbot unified log: https://uberchromegw.corp.google.com/i/chromeos/builders/cyan-paladin/builds/609/steps/steps/logs/stdio

The logdog unified log would be: https://luci-logdog.appspot.com/v/?s=chromeos%2Fbb%2Fchromeos%2Fcyan-paladin%2F609%2F%2B%2Frecipes%2F**%2Fstdout

build landing page needs a link to this.
 
Cc: dgarr...@chromium.org
Owner: d...@chromium.org
Status: Assigned (was: Untriaged)
--> dnj@
We could build the url manually in cbuildbot and create a link. Is this the way to go, or is there a better way to get this functionality? None of the logdog logic is in cbuildbot, so it seems to be the wrong place for url manipulation.

If it's down to custom URL, please assign this bug to me.

Comment 2 by autumn@chromium.org, Oct 11 2016

Labels: -current-issue
ping. This is easy to implement in cbuildbot, but that seems to be the wrong place for it.
We should add it to the same place where the rest of the logdog links are genearted. PTAL.

Once we do this, we can start removing the buildbot log links (why have duplicates, especially because people keep linking to the ephermeral logs by habit)

Comment 4 by d...@chromium.org, Nov 21 2016

I haven't had much time to work on LogDog stuff lately, sorry. The place to implement this is definitely in "Annotee", the LogDog tee parser, not cbuildbot. Is this something that is >P2?
Not >P2.
Can you ping me a link to the code anyway? :)

Comment 6 by d...@chromium.org, Nov 21 2016

Sure! The program that emits the links is called "Annotee", and is homed here: https://github.com/luci/luci-go/tree/master/logdog/client/annotee

Basically it sits in between the running process (recipe engine, cbuildbot) and parses the STDOUT/STDERR streams. It tees the data to BuildBot (injecting links as needed) and also tees the data as a LogDog stream.

In this case, we would want to emit an "alias" link called "stdio" in the first step, and alias it to "<prefix>/+/**/stdout" and "<prefix>/+/**/stderr".
Status: Verified (was: Assigned)
I have no idea who decided to do this (dnj?), but I can confirm that an "all" link has now appeared on the buildbot build landing page.

Comment 8 by d...@chromium.org, Dec 13 2016

Yeah I put this in on Friday. Didn't even think of this bug when I did it, so cool free bug fix.

Sign in to add a comment