New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 654888 link

Starred by 1 user
Status: Verified
Owner: ----
Closed: Oct 2016
Cc:
█ cernekee@chromium.org
w...@rock-chips.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

rockchip_panic_notify() does not print full 64-bit addresses

Project Member Reported by cernekee@chromium.org, Oct 11 2016 
If a CPU is wedged at panic time, the panic notifier code queries the PCSR registers to try to figure out what is happening on that CPU.  The lower 32 bits from EDPCSRlo on rk3399 provide useful data, but the upper 32 bits frmo EDPCSRhi are always 0.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 12 2016

Labels: merge-merged-release-R55-8872.B-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/ac0454a1dd647334404d8d2fa598c0dd33455993

commit ac0454a1dd647334404d8d2fa598c0dd33455993
Author: Kevin Cernekee <cernekee@chromium.org>
Date: Tue Oct 11 23:26:01 2016

CHROMIUM: soc: rockchip: Fix addresses in panic notifier

Currently the panic notifier only prints the lower 32 bits of the
sampled PC from each wedged CPU.  Fix it so that it prints the full
64-bit PC.

BUG= chromium:654888 
TEST=force a hard lockup on a CPU, then check console-ramoops

Change-Id: I20eb96c24d77ead85f39038658a94c94a6f7a58e
Signed-off-by: Kevin Cernekee <cernekee@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/396960
Reviewed-by: Brian Norris <briannorris@chromium.org>
Tested-by: Brian Norris <briannorris@chromium.org>
Commit-Queue: Brian Norris <briannorris@chromium.org>

[modify] https://crrev.com/ac0454a1dd647334404d8d2fa598c0dd33455993/drivers/soc/rockchip/panic_handler.c
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 12 2016

Labels: merge-merged-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/8caeb8e8838eac7eec7c45e1096da800e3371ac3

commit 8caeb8e8838eac7eec7c45e1096da800e3371ac3
Author: Kevin Cernekee <cernekee@chromium.org>
Date: Tue Oct 11 23:26:01 2016

CHROMIUM: soc: rockchip: Fix addresses in panic notifier

Currently the panic notifier only prints the lower 32 bits of the
sampled PC from each wedged CPU.  Fix it so that it prints the full
64-bit PC.

BUG= chromium:654888 
TEST=force a hard lockup on a CPU, then check console-ramoops

Change-Id: I20eb96c24d77ead85f39038658a94c94a6f7a58e
Signed-off-by: Kevin Cernekee <cernekee@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/396429
Commit-Ready: Brian Norris <briannorris@chromium.org>
Tested-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>

[modify] https://crrev.com/8caeb8e8838eac7eec7c45e1096da800e3371ac3/drivers/soc/rockchip/panic_handler.c

Comment 3 by diand...@chromium.org, Oct 12 2016

Labels: M-55 Merge-Merged
Status: Fixed (was: Untriaged)

Comment 4 by ka...@chromium.org, Dec 1 2016

Status: Verified (was: Fixed)
Bulk-Verify
►

Sign in to add a comment