New issue
Advanced search Search tips

Issue 654887 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Mash isn't triggering activating a new window when active window visibility changes

Project Member Reported by sky@chromium.org, Oct 11 2016

Issue description

A specific test that fails is MruWindowTrackerTest.MinimizedWindowsAreLru.

The code that needs to be called is in AshFocusRules.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/829e1b23a8e607028515ccf5376314b4d203bcc1

commit 829e1b23a8e607028515ccf5376314b4d203bcc1
Author: sky <sky@chromium.org>
Date: Tue Oct 11 23:54:40 2016

Converts ash/wm/mru_window_tracker_unittest.cc to use AshTest

And nukes the wm one. I'll move the file to common in a follow on
patch. In order to get this working I needed to add a couple of
things:

. Wire up WmWindowProperty::EXCLUDE_FROM_MRU in WmWindowMus.
. Fix bug in WmShell that resulted in OnWindowActivated() not being
  called correctly (and with wrong args).
. Make ui::WindowObserver::OnWindowDestroyed() be called at the same
  time as that of aura::WindowObserver.

BUG= 618058 ,  654887 
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2411913003
Cr-Commit-Position: refs/heads/master@{#424603}

[modify] https://crrev.com/829e1b23a8e607028515ccf5376314b4d203bcc1/ash/BUILD.gn
[modify] https://crrev.com/829e1b23a8e607028515ccf5376314b4d203bcc1/ash/common/BUILD.gn
[modify] https://crrev.com/829e1b23a8e607028515ccf5376314b4d203bcc1/ash/common/wm/window_state.cc
[modify] https://crrev.com/829e1b23a8e607028515ccf5376314b4d203bcc1/ash/mus/BUILD.gn
[modify] https://crrev.com/829e1b23a8e607028515ccf5376314b4d203bcc1/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/829e1b23a8e607028515ccf5376314b4d203bcc1/ash/mus/bridge/wm_window_mus.cc
[modify] https://crrev.com/829e1b23a8e607028515ccf5376314b4d203bcc1/ash/mus/property_util.cc
[modify] https://crrev.com/829e1b23a8e607028515ccf5376314b4d203bcc1/ash/mus/property_util.h
[delete] https://crrev.com/fa1eb5b3cfb4bee9bf72f7721c73d3a50e5b3932/ash/mus/wm/mru_window_tracker_unittest.cc
[modify] https://crrev.com/829e1b23a8e607028515ccf5376314b4d203bcc1/ash/wm/mru_window_tracker_unittest.cc
[modify] https://crrev.com/829e1b23a8e607028515ccf5376314b4d203bcc1/services/ui/public/cpp/window.cc
[modify] https://crrev.com/829e1b23a8e607028515ccf5376314b4d203bcc1/services/ui/public/interfaces/window_manager.mojom

Comment 2 by sky@chromium.org, Mar 7 2017

Owner: sky@chromium.org
Status: Fixed (was: Untriaged)
This now test passes, so I'll reenable. Most likely because of the move to aura-mus.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4194a955fd464fd5182ad9e87f8519558310e229

commit 4194a955fd464fd5182ad9e87f8519558310e229
Author: sky <sky@chromium.org>
Date: Tue Mar 07 18:52:47 2017

Reenables MruWindowTrackerTest.MinimizedWindowsAreLru in mash

This test now passes, most likely because of the move to aura.

BUG= 654887 
TEST=test only change
R=jamescook@chromium.org
TBR=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2740583002
Cr-Commit-Position: refs/heads/master@{#455160}

[modify] https://crrev.com/4194a955fd464fd5182ad9e87f8519558310e229/ash/common/wm/mru_window_tracker_unittest.cc

Comment 4 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 5 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment