New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 654876 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 588377



Sign in to add a comment

Include active state to avatar button

Project Member Reported by bettes@chromium.org, Oct 11 2016

Issue description

Include a active state on the avatar button when menu is open. Specs are identical to that of the pressed state. 

PREVIEW
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Desktop%20Sign%20In/user_menu-button/P%20-%20macOSX#%2F04-signed-in-pressed.png%3Fz=width

SPEC
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Desktop%20Sign%20In/user_menu-button#%2FSPEC%20-%20user-menu-button.png%3Fz=width
 
Screen Shot 2016-10-11 at 2.07.30 PM.png
13.3 KB View Download
04-signed-in-pressed.png
147 KB View Download
Blocking: 588377
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/150c941e115f73ac37c7ae2b840d2420f1c6f45e

commit 150c941e115f73ac37c7ae2b840d2420f1c6f45e
Author: spqchan <spqchan@chromium.org>
Date: Fri Oct 28 16:58:03 2016

[Mac] Clean up AvatarButtonController

Checks for Material Design had recently been removed. However,
there's still a lot of leftover code. This CL cleans up
AvatarButtonController so that it will be easier to add new things to it.

BUG= 654876 

Review-Url: https://codereview.chromium.org/2455323002
Cr-Commit-Position: refs/heads/master@{#428395}

[modify] https://crrev.com/150c941e115f73ac37c7ae2b840d2420f1c6f45e/chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm

Status: Fixed (was: Assigned)

Sign in to add a comment