New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 654875 link

Starred by 1 user
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: Oct 2016
Cc:
dbeam@chromium.org
tbuck...@chromium.org
bettes@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Site Settings] blocked, allowed, and exceptions lists

Project Member Reported by dschuyler@chromium.org, Oct 11 2016 
In chrome://md-settings/siteSettings/microphone (and other pages within /siteSettings/) there are lists of sites under headings like Blocked, Allowed, and Exceptions. 

Problem(A): The relationship between the three is not clear to new users (based on reactions from members of the chrome-lax team).

Problem(B): When changing the setting on a site to Block from Allowed or Exceptions, the UI will jump around or the site will seem to disappear.

Problem(C): Some categories have more than two categories (Blocked and Allowed don't cover the possible states). I think Flash is or will be an example.

Problem(D): There is an unclear number trailing the category title (such as "Blocked - 0"). After some tinkering, SWEs I've talked with about it tend to figure out that it's a count of the items in the list. The issue is that it requires figuring out (i.e. it's unclear).

Proposed solutions:
Should we go back to the flat list of sites, with each site showing their state? That may address all the problems listed above.

If we choose to continue with the separate categories, I'll break out the list of problems into separate bugs.
Screenshot from 2016-10-11 13:55:53.png
15.8 KB View Download
Screenshot from 2016-10-11 13:56:05.png
11.0 KB View Download

Comment 1 by dbeam@chromium.org, Oct 12 2016 

so I think our UX sync today covered most of this:

* drop the expand behavior for now (just always open)
* keep lists the same regardless of default setting (i.e. just keep "Block" and "Allow" the same at all times, don't ever change to "Exceptions")
* drop the "- 0" label if both lists are always expanded
* change the "Add site exception" to "| ADD" as a secondary button

the only thing we didn't talk about are lists for other than "Allow" or "Block"

Comment 2 by tbuck...@chromium.org, Oct 17 2016

Cc: tbuck...@chromium.org
Owner: dschuyler@chromium.org
Status: Assigned (was: Untriaged)
If there are other lists (I believe there are only a few sections that have a state in-between "Allow" and "Block"), it should be placed in between the Allow/Block lists.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d8adf8d41aee5f64a004bf89ec3c0cbaa7b4cb2

commit 3d8adf8d41aee5f64a004bf89ec3c0cbaa7b4cb2
Author: dschuyler <dschuyler@chromium.org>
Date: Thu Oct 20 18:22:48 2016

[MD settings] content settings add site button; layout fixes

This CL moves the 'Add site exception' button to an 'Add' button on the
header line of the site exceptions. The filter for the site data has
been moved into the list of sites. The remove all local cookie and
storage button has been removed from the list of cookies (it's still
available in the dialog).

Also, the misalignment of .secondary text in checkboxes and content
settings has been fixed.

BUG= 654875 ,  655036 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://chromiumcodereview.appspot.com/2429973003
Cr-Commit-Position: refs/heads/master@{#426536}

[modify] https://crrev.com/3d8adf8d41aee5f64a004bf89ec3c0cbaa7b4cb2/chrome/app/settings_strings.grdp
[modify] https://crrev.com/3d8adf8d41aee5f64a004bf89ec3c0cbaa7b4cb2/chrome/browser/resources/settings/controls/settings_checkbox.html
[modify] https://crrev.com/3d8adf8d41aee5f64a004bf89ec3c0cbaa7b4cb2/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/3d8adf8d41aee5f64a004bf89ec3c0cbaa7b4cb2/chrome/browser/resources/settings/site_settings/site_data.html
[modify] https://crrev.com/3d8adf8d41aee5f64a004bf89ec3c0cbaa7b4cb2/chrome/browser/resources/settings/site_settings/site_data.js
[modify] https://crrev.com/3d8adf8d41aee5f64a004bf89ec3c0cbaa7b4cb2/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/3d8adf8d41aee5f64a004bf89ec3c0cbaa7b4cb2/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/3d8adf8d41aee5f64a004bf89ec3c0cbaa7b4cb2/chrome/browser/resources/settings/site_settings/site_settings_category.html
[modify] https://crrev.com/3d8adf8d41aee5f64a004bf89ec3c0cbaa7b4cb2/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/3d8adf8d41aee5f64a004bf89ec3c0cbaa7b4cb2/chrome/test/data/webui/settings/site_list_tests.js

Comment 4 by dschuyler@chromium.org, Oct 20 2016

Status: Fixed (was: Assigned)

Comment 5 by dschuyler@chromium.org, Oct 20 2016 

FYI, Problem(B) was 'as designed'.
►

Sign in to add a comment