New issue
Advanced search Search tips

Issue 654854 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3.6% regression in speedometer at 424392:424400

Project Member Reported by tdres...@chromium.org, Oct 11 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=654854

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgzfaMtwoM


Bot(s) for this bug's original alert(s):

chromium-rel-win8-dual
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Oct 12 2016

Cc: jgruber@chromium.org
Owner: jgruber@chromium.org

=== Auto-CCing suspected CL author jgruber@chromium.org ===

Hi jgruber@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : [regexp] Port test, match, and search
Author  : jgruber
Commit description:
  
This CL ports RegExp.prototype.test, RegExp.prototype.match
and RegExp.prototype.search to C++.

Performance regressions are expected but should be improved
in an upcoming CL.

BUG= v8:5339 

Review-Url: https://codereview.chromium.org/2394713003
Cr-Commit-Position: refs/heads/master@{#40122}
Commit  : 80f3c6ce7702c0cc28388ae4f084c23870a9aa4f
Date    : Mon Oct 10 13:57:20 2016


===== TESTED REVISIONS =====
Revision                       Mean     Std Dev  N  Good?
chromium@424391                4292.57  10.1909  5  good
chromium@424396                4316.05  22.0686  5  good
chromium@424398                4298.48  31.4135  5  good
chromium@424398,v8@640ae3f9d2  4282.85  17.4903  5  good
chromium@424398,v8@80f3c6ce77  4439.79  21.6879  5  bad    <--
chromium@424398,v8@d5d283b27d  4426.88  29.1165  5  bad
chromium@424398,v8@853e176f29  4427.1   8.42462  5  bad
chromium@424398,v8@b884a51ff2  4418.68  11.4182  5  bad
chromium@424399                4383.57  31.0931  5  bad
chromium@424400                4399.37  12.4413  5  bad

Bisect job ran on: win_8_perf_bisect
Bug ID: 654854

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests speedometer
Test Metric: Total/Total
Relative Change: 2.49%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/win_8_perf_bisect/builds/2239
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8999069193978822704


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5770721576353792

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Cc: yangguo@chromium.org
Status: Assigned (was: Untriaged)
Some performance regression is expected from this CL, and I'll look into fixing it soon.
Issue 655128 has been merged into this issue.
Components: Blink>JavaScript
Labels: ReleaseBlock-Beta
Issue 656050 has been merged into this issue.
Cc: hablich@chromium.org
Most of this has been fixed by recent fast paths and TurboFan ports.

BackBoneJS-TodoMVC and jQuery-TodoMVC are still regressed by 3%, probably by @@split, @@match or @@search. We're planning to move these to TurboFan as well, just not immediately.

@hablich are we good to go as-is for the next release? 

Issue 656529 has been merged into this issue.
From 656529: mostly fixed. Exceptions are e.g. wikipedia.org-visual-editor.
It seems to be a net win and 3 % is not a lot so I think the regressions are ok for now.
Status: Fixed (was: Assigned)
Opened new bug for the couple remaining regressions: https://bugs.chromium.org/p/v8/issues/detail?id=5562

Sign in to add a comment