VR: Full screen video is black in VR mode. |
|||||
Issue descriptionVersion: First saw in 55, but mainly 56 where it will need to be fixed OS: Android What steps will reproduce the problem? (1) Go to a web page with a video element (I used http://camendesign.com/code/video_for_everybody/test.html) (2) Enter VR mode (3) Start playing video, observe normal output in content quad (4) Click Fullscreen video button What is the expected output? Content quad outputs video and nothing else (full screen using the dimensions of the quad) What do you see instead? Black quad, but controls do render on top of the black and exiting full screen returns to showing the video and surrounding content in VR mode (albeit with a separate bug for showing OS controls on top of VR mode which should not be happening).
,
Nov 11 2016
,
Nov 15 2016
,
Dec 5 2016
,
Dec 6 2016
Sent out https://codereview.chromium.org/2439543003/ for initial review. The current patchset fixes the issue if the video was started after entering vr, but the black screen still shows up if the video is started prior to entering vr and then fullscreened in vr.
,
Dec 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ff7bf42dc2fac16bf7a63507be68e655f3ccfcc commit 2ff7bf42dc2fac16bf7a63507be68e655f3ccfcc Author: amp <amp@chromium.org> Date: Sat Dec 17 00:06:52 2016 Do not use overlays when VR shell is enabled. Fixes VR Shell showing black screen for video when fullscreening. BUG= 654851 Review-Url: https://codereview.chromium.org/2439543003 Cr-Commit-Position: refs/heads/master@{#439241} [modify] https://crrev.com/2ff7bf42dc2fac16bf7a63507be68e655f3ccfcc/content/renderer/render_frame_impl.cc [modify] https://crrev.com/2ff7bf42dc2fac16bf7a63507be68e655f3ccfcc/media/blink/webmediaplayer_impl.cc [modify] https://crrev.com/2ff7bf42dc2fac16bf7a63507be68e655f3ccfcc/media/blink/webmediaplayer_impl.h
,
Dec 19 2016
This is now 'fixed' in that full screen video will work when vr shell is enabled. It is using an inefficient path, and we should be able to do better, so I filed issue 673886 to track a more complete implementation. Getting that final fix in should block enabling vr shell for actual users. The current solution disables all overlays for web media. This is less efficient, but will only be for the small number of users who enable the vr shell flag and should be fine until we begin external user experiments. I've verified this fix works on Canary 57.0.2954.0
,
Jan 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea73f799eb7fe7a9b5836f2c491bd99dbf933089 commit ea73f799eb7fe7a9b5836f2c491bd99dbf933089 Author: amp <amp@chromium.org> Date: Thu Jan 19 04:05:39 2017 Skip video overlay surface management when in VR. This changes the overlay surface from being disabled when VrShell flag was enabled at all to only when VrShell is actually active. It also re-enables VrShell testing config. BUG= 654851 Review-Url: https://codereview.chromium.org/2643893002 Cr-Commit-Position: refs/heads/master@{#444634} [modify] https://crrev.com/ea73f799eb7fe7a9b5836f2c491bd99dbf933089/content/browser/media/android/browser_surface_view_manager.cc [modify] https://crrev.com/ea73f799eb7fe7a9b5836f2c491bd99dbf933089/content/browser/renderer_host/render_widget_host_view_android.cc [modify] https://crrev.com/ea73f799eb7fe7a9b5836f2c491bd99dbf933089/content/browser/renderer_host/render_widget_host_view_android.h [modify] https://crrev.com/ea73f799eb7fe7a9b5836f2c491bd99dbf933089/content/browser/renderer_host/render_widget_host_view_base.cc [modify] https://crrev.com/ea73f799eb7fe7a9b5836f2c491bd99dbf933089/content/browser/renderer_host/render_widget_host_view_base.h [modify] https://crrev.com/ea73f799eb7fe7a9b5836f2c491bd99dbf933089/content/renderer/render_frame_impl.cc [modify] https://crrev.com/ea73f799eb7fe7a9b5836f2c491bd99dbf933089/media/blink/webmediaplayer_impl.cc [modify] https://crrev.com/ea73f799eb7fe7a9b5836f2c491bd99dbf933089/media/blink/webmediaplayer_impl.h [modify] https://crrev.com/ea73f799eb7fe7a9b5836f2c491bd99dbf933089/testing/variations/fieldtrial_testing_config.json
,
Jan 19 2017
Note that the latest fix resolves the issue in a way that does not impact video overlays in non-vr mode and so is not a blocker for beginning VrShell experiments any more. Issue 673886 is still the desired long term solution, but not strictly required at this time. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sko...@chromium.org
, Oct 11 2016