md-settings: clear browsing data dialog is spacious and weird |
|||||||||||||||
Issue descriptionsteps to reproduce: 0. visit chrome://md-settings/clearBrowserData (or somehow get to the new, material clear browsing data dialog) what do you expect? something that usefully conveys information in an equally polished way as chrome://settings/clearBrowserData (the older version we're trying to replace). what do you get instead? the new dialog looks far too spacious when checkboxes are unchecked (each row is 56px high even though the text and checkbox are only 16px high (default font + zoom). the ripple is 40px, so I suppose the minimum we can have is 40px. there is a rule in the CSS that attempts to do this, but it's being overidden (functionally) within the shadow DOM of <settings-checkbox>. additionally, there was talk of ensuring that there's always half a checkbox poking out in bug 652027 to appease overlay scrolling platforms (i.e. Mac) but it seems silly and unsustainable to me to have to make every custom-scrollable element have some partial row item showing. additionally, unchecking some of these checkboxes would probably decrease their height from 56px (checked, 2 lines of text) to 40px (unchecked, 1 line of text) and might end up making the logic harder to get right. so, I think we should do one of two things: a) make checkbox rows shorter when unchecked (so the spacing looks saner) b) always show the second line of text (i.e. what would be cleared) if we make unchecked rows shorter, it could make it hard for some users with overlay scrolling to know they can scroll in this dialog (but I think that's a general issue with overlay scrolling to begin with). if we always show secondary text, it might be easier to predictably show half a row (all rows will be 56px always), but there are silly secondary texts lying around like "none" that look like bugs.
,
Oct 14 2016
Option A (make checkbox rows shorter when unchecked) is expected. See mocks and note the max-height of 561px. https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-Privacy_04.png%3Fz=width
,
Oct 14 2016
,
Oct 14 2016
,
Dec 15 2016
We have been discussing this with maxwalker@ and came to the conclusion that b) would be the best. Let's just confirm with the UI review, as the current behavior was explicitly discussed in the past as a way to make the UI less cluttered.
,
Jan 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e36f41845d3f6232aaeddf68fcde9576c7446344 commit e36f41845d3f6232aaeddf68fcde9576c7446344 Author: msramek <msramek@chromium.org> Date: Thu Jan 12 21:27:38 2017 Always show counters in the material design Clear Browsing Data dialog. Previously, they were only shown when the corresponding datatype was checked. This led to uneven spacing between checkboxes and arguably strange visual behavior where text was appearing and disappearing. See the linked bug for screenshots. BUG= 654812 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2623033003 Cr-Commit-Position: refs/heads/master@{#443364} [modify] https://crrev.com/e36f41845d3f6232aaeddf68fcde9576c7446344/chrome/browser/browsing_data/autofill_counter_browsertest.cc [modify] https://crrev.com/e36f41845d3f6232aaeddf68fcde9576c7446344/chrome/browser/browsing_data/cache_counter.cc [modify] https://crrev.com/e36f41845d3f6232aaeddf68fcde9576c7446344/chrome/browser/browsing_data/cache_counter.h [modify] https://crrev.com/e36f41845d3f6232aaeddf68fcde9576c7446344/chrome/browser/browsing_data/cache_counter_browsertest.cc [modify] https://crrev.com/e36f41845d3f6232aaeddf68fcde9576c7446344/chrome/browser/browsing_data/history_counter_browsertest.cc [modify] https://crrev.com/e36f41845d3f6232aaeddf68fcde9576c7446344/chrome/browser/browsing_data/media_licenses_counter_browsertest.cc [modify] https://crrev.com/e36f41845d3f6232aaeddf68fcde9576c7446344/chrome/browser/browsing_data/passwords_counter_browsertest.cc [modify] https://crrev.com/e36f41845d3f6232aaeddf68fcde9576c7446344/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html [modify] https://crrev.com/e36f41845d3f6232aaeddf68fcde9576c7446344/chrome/browser/resources/settings/controls/settings_toggle_button.html [modify] https://crrev.com/e36f41845d3f6232aaeddf68fcde9576c7446344/chrome/test/data/webui/settings/privacy_page_test.js [modify] https://crrev.com/e36f41845d3f6232aaeddf68fcde9576c7446344/components/browsing_data/core/counters/autofill_counter.cc [modify] https://crrev.com/e36f41845d3f6232aaeddf68fcde9576c7446344/components/browsing_data/core/counters/autofill_counter.h [modify] https://crrev.com/e36f41845d3f6232aaeddf68fcde9576c7446344/components/browsing_data/core/counters/browsing_data_counter.cc [modify] https://crrev.com/e36f41845d3f6232aaeddf68fcde9576c7446344/ios/chrome/browser/browsing_data/cache_counter.cc [modify] https://crrev.com/e36f41845d3f6232aaeddf68fcde9576c7446344/ios/chrome/browser/browsing_data/cache_counter.h [modify] https://crrev.com/e36f41845d3f6232aaeddf68fcde9576c7446344/ios/chrome/browser/browsing_data/cache_counter_unittest.cc
,
Jan 12 2017
,
May 8 2017
Chrome OS 9532.0.0, 60.0.3092.0 |
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by dbeam@chromium.org
, Oct 11 2016