estade@, looks like this is regressed in https://codereview.chromium.org/2218323002

In LogoutButtonTray::UpdateButtonTextAndImage, we do
  button_->SetMinSize(gfx::Size(0, kTrayItemSize));

When we are NOT using MD and |button_| is a LogoutButton, we should use GetTrayConstant(TRAY_ITEM_HEIGHT_LEGACY) instead.

Could you take a look? Thanks.

happy to work on this, but won't be able to get to it till after I'm back from vacation late next week.

Let me create a quick patch and give it a shot then.

https://codereview.chromium.org/2414533002/

Deleted: legacy_shelf.png 59.2 KB

	legacy_shelf.png 59.2 KB View Download

Deleted: md_shelf.png 57.1 KB

	md_shelf.png 57.1 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f35d15d1ad0fa7a5f87f5ad47d4fc33aa695d66

commit 6f35d15d1ad0fa7a5f87f5ad47d4fc33aa695d66
Author: xiyuan <xiyuan@chromium.org>
Date: Wed Oct 12 15:53:33 2016

ash: Use legacy size for legacy logout button.

BUG= 654803 

Review-Url: https://codereview.chromium.org/2414533002
Cr-Commit-Position: refs/heads/master@{#424750}

[modify] https://crrev.com/6f35d15d1ad0fa7a5f87f5ad47d4fc33aa695d66/ash/common/system/chromeos/session/logout_button_tray.cc

Fixed in M55.

Let me know if we want to merge the fix to M54.

Oops, CL in #6 does not get into M-55. Requesting merge.

Your change meets the bar and is auto-approved for M55 (branch: 2883)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ce691c1721f4fa3f865680c4b563630cc79a2f6

commit 3ce691c1721f4fa3f865680c4b563630cc79a2f6
Author: Xiyuan Xia <xiyuan@google.com>
Date: Wed Oct 19 17:00:35 2016

Merge "ash: Use legacy size for legacy logout button."

> BUG= 654803 
>
> Review-Url: https://codereview.chromium.org/2414533002
> Cr-Commit-Position: refs/heads/master@{#424750}
> (cherry picked from commit 6f35d15d1ad0fa7a5f87f5ad47d4fc33aa695d66)

Review URL: https://codereview.chromium.org/2431313004 .

Cr-Commit-Position: refs/branch-heads/2883@{#188}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/3ce691c1721f4fa3f865680c4b563630cc79a2f6/ash/common/system/chromeos/session/logout_button_tray.cc

Padding looks ok in Candy device
 
Columns
M	ChromeOS	Chrome	ARC	Type	Channel
55	8872.22.0	55.0.2883.25	3388538	release	dev

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ce691c1721f4fa3f865680c4b563630cc79a2f6

commit 3ce691c1721f4fa3f865680c4b563630cc79a2f6
Author: Xiyuan Xia <xiyuan@google.com>
Date: Wed Oct 19 17:00:35 2016

Merge "ash: Use legacy size for legacy logout button."

> BUG= 654803 
>
> Review-Url: https://codereview.chromium.org/2414533002
> Cr-Commit-Position: refs/heads/master@{#424750}
> (cherry picked from commit 6f35d15d1ad0fa7a5f87f5ad47d4fc33aa695d66)

Review URL: https://codereview.chromium.org/2431313004 .

Cr-Commit-Position: refs/branch-heads/2883@{#188}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/3ce691c1721f4fa3f865680c4b563630cc79a2f6/ash/common/system/chromeos/session/logout_button_tray.cc

[Automated comment] removing mislabelled merge-merged-2840

[Automated comment] removing mislabelled merge-merged-2840