New issue
Advanced search Search tips

Issue 654793 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 343579



Sign in to add a comment

Data Reduction proxy should record the scheme of the proxy used

Project Member Reported by tbansal@chromium.org, Oct 11 2016

Issue description

After fetching a request successfully, data reduction proxy should record the scheme of the proxy through which the request was fetched. This would be useful for quantifying the number of requests that were fetched via an HTTPS proxy vs. a QUIC proxy.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3798161a835bcfd9b257074093b4a44422d9a1a

commit f3798161a835bcfd9b257074093b4a44422d9a1a
Author: tbansal <tbansal@chromium.org>
Date: Wed Oct 12 16:47:35 2016

Record scheme of the data reduction proxy server

UMA is added which records the scheme of the data reduction
proxy server used. This would be used for determining how
many requests were successfully fetched using HTTPS data
reduction proxy vs. QUIC data reduction proxy.

BUG= 654793 

Review-Url: https://codereview.chromium.org/2407073002
Cr-Commit-Position: refs/heads/master@{#424764}

[modify] https://crrev.com/f3798161a835bcfd9b257074093b4a44422d9a1a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc
[modify] https://crrev.com/f3798161a835bcfd9b257074093b4a44422d9a1a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc
[modify] https://crrev.com/f3798161a835bcfd9b257074093b4a44422d9a1a/tools/metrics/histograms/histograms.xml

Labels: Merge-Request-55
Labels: -Merge-Request-55
Status: Fixed (was: Started)
Labels: M-56
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10939b0d35b8e8ac58010b67c860f2a5a53da5d3

commit 10939b0d35b8e8ac58010b67c860f2a5a53da5d3
Author: tbansal <tbansal@chromium.org>
Date: Thu Oct 20 00:11:27 2016

Record Proxy Server scheme accurately

The scheme of the proxy server is current read from
proxy_info which may not match the scheme of the proxy
server actually used (e.g., when there is a race between
HTTP2 and QUIC connection). This CL fixes the bug by reading
the scheme from the proxy server set in the request (instead
of from the proxy_info).

BUG= 654793 

Review-Url: https://chromiumcodereview.appspot.com/2426903003
Cr-Commit-Position: refs/heads/master@{#426346}

[modify] https://crrev.com/10939b0d35b8e8ac58010b67c860f2a5a53da5d3/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc
[modify] https://crrev.com/10939b0d35b8e8ac58010b67c860f2a5a53da5d3/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc
[modify] https://crrev.com/10939b0d35b8e8ac58010b67c860f2a5a53da5d3/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.cc
[modify] https://crrev.com/10939b0d35b8e8ac58010b67c860f2a5a53da5d3/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h
[modify] https://crrev.com/10939b0d35b8e8ac58010b67c860f2a5a53da5d3/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h

Blocking: 343579

Sign in to add a comment