New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 654777 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

HTMLTableRowElement::sectionRowIndex implementation should follow specification more

Reported by rob.b...@samsung.com, Oct 11 2016

Issue description

HTMLTableRowElement::sectionRowIndex implmenetation right now is very simple and does not follow the specification closely:
https://html.spec.whatwg.org/#dom-tr-sectionrowindex

Using internal rows() implementation here should be efficient since these are cached.
 
Components: Blink>Layout>Table
Components: -Blink>Layout>Table Blink>DOM

Comment 3 by tkent@chromium.org, Oct 14 2016

Components: -Blink>DOM Blink>HTML>Table

Comment 4 by tkent@chromium.org, Oct 14 2016

Status: ava (was: Untriaged)

Comment 5 by tkent@chromium.org, Oct 14 2016

Status: Available (was: ava)
Owner: rob.b...@samsung.com
Status: Assigned (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9a5c42229e57de44db61c45ee9cf71210f3c205

commit c9a5c42229e57de44db61c45ee9cf71210f3c205
Author: rob.buis <rob.buis@samsung.com>
Date: Thu Oct 27 13:42:32 2016

Make sectionRowIndex be more conforming to spec

Make sectionRowIndex be more conforming to spec by
reusing the rows getters from HTMLTableSectionElement
and HTMLTableElement, which is also potentially more
efficient since they use caching.

BUG= 654777 

Review-Url: https://codereview.chromium.org/2455623003
Cr-Commit-Position: refs/heads/master@{#428013}

[modify] https://crrev.com/c9a5c42229e57de44db61c45ee9cf71210f3c205/third_party/WebKit/Source/core/html/HTMLTableRowElement.cpp

Status: Fixed (was: Assigned)
Fixed by r428013.

Sign in to add a comment