New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 654769 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

mp3 files crash on SDCard

Reported by prosc...@genepoolsports.com, Oct 11 2016

Issue description

Chrome Version       : 53.0.2785.154
OS Version: 8530.96.0
URLs (if applicable) :
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari 5:
  Firefox 4.x:
     IE 7/8/9:

What steps will reproduce the problem?
1.Double click mp3 files on SD CArd
2.Double click same mp3 files on Chromebook 13 download folder
3.Use Enjoy Music Player to launch the same files on SD Card.

What is the expected result?
1. Crashes and restarts the Chromebook
2. Plays just fine
3. Plays just fine


What happens instead of that?


Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (X11; CrOS x86_64 8530.96.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.154 Safari/537.36

This only began after the last update.

 
Cc: rohi...@chromium.org vsu...@chromium.org avkodipelli@chromium.org hsiangc@chromium.org
Labels: Needs-Feedback
proscout@ Is this issue still happening, If so can please submit a feedback report by using Alt + Shift + i key combination and add bug number in description. Also please update here once you submit the report. Thanks! 
Still crashes. When I double click an mp3 file located on my MicroSD card, the Chromebook crashes. Screen goes completely black, a few seconds later it reloads Chrome and tries to restore the last page as well as the audio file. If I don't quickly kill the audio player and it tries to load the song, after the title is displayed, a second later it crashes again. It will go into an endless loop of crashing unless I kill the audio file immediately on restart.

If I play these same songs from Enjoy Music player or others, no problem. Filed a bug report as suggested.
Cc: dgreid@chromium.org ka...@chromium.org
Components: OS>Kernel>Audio
Labels: -Needs-Feedback
we're Unable to reproduce issue locally.
proscout@ Can you please provide mp3 file for testing. Thanks!

dgreid@ feedback id : 14293093237, please triage if anything find suspicious in logs.  Thanks!
Tried to use the G Suite debug tool but it seems to have issues. Attached is the debug log from my HP Chromebook 13.
debug-logs_20161018-224146.tgz
2.8 MB Download
Here's an mp3 file. Doesn't matter which mp3 I use, they all crash the chromebook unless I double click them from the download folder on the local drive. 
Believe Me - Moist.mp3
6.4 MB Download
I just did a little test. I thought, maybe something with the formatting of the MicroSD Card. So I moved the files off to the local drive. Strange thing is, its now doing it on the local drive as well. But the files cannot be corrupt, because the Enjoy music player plays them without issue. It only crashes if I double click from the file browser opening in the native audio player.
Here's an additional note of interest. I decided in an effort to complete eliminate any kind of weird file corruption, to delete the mp3 files entirely,reformat the SD Card in Chrome and copy the files back from my cell phone, connected by USB. Here's the strange thing, if I use the file browser on Chromebook to navigate my phone connected by USB, I can double click the file and play it without issue via the Chromebook audio player. The same file will not play if its located on my Chromebook or the SD card in my chromebook and it doesn't matter what mp3 file.  When I was first copying files from my phone to my Chromebook, I only copied 3 or 4 files. Those all played fine. Once I copied all the files, suddenly I couldn't launch them from the Chromebook anymore and it caused the crashing again. Is there some sort of issue with how many files?
Cc: fukino@chromium.org
Ok one last point in reference to my last post. Since the first few files played without issue until I added over 1000 mp3 files, I then decided, lets delete a bunch and see if those will again play without crashing. Well guess what...? I deleted a little better than half of the files and again I'm able to play all the files on my SD card or device without crashing. It seems to have something to do with how many mp3 files are on the device.
Thanks for the information, We'll dig into this. 
Owner: avkodipelli@chromium.org
Status: Assigned (was: Unconfirmed)
Components: -OS>Kernel>Audio Platform>Apps>MediaPlayer
Owner: fukino@chromium.org
Able to reproduce issue on lulu device on 53.0.2785.154/8530.96.0 while playing mp3 audio from a memory card which has around 850 mp3 files.

Crash ID : fba7f8eb00000000 , 0f9f51b900000000

Feedback report: 14807854257

I'll verify on M54 and M55.
Crash is also observed on M54(54.0.2840.79/8743.76.0)
Id : 57cc84eb00000000
Labels: -Pri-3 M-55 ReleaseBlock-Stable Pri-1
Issue is also observed on M55(8872.27.0/55.0.2883.29).

Also observed crashes related bug(https://bugs.chromium.org/p/chromium/issues/detail?id=634413) 

Crash Id : 840331b900000000 , 1e8031b900000000

On M55, sometimes it making system to hang for a while. 
Status: Started (was: Assigned)
audio player reads audio files' metadata in the same directory.
Reading large number of audio files resulted in running out of open file descriptors limit.

I'll update the audio player to throttle the metadata reading. (Up to 25 files at the same time.)
Cc: rookrishna@chromium.org
One more observation: Observed browser crash while opening around 600 pdf files(15KB each) from internal downloads or from memory card. 
crash ID's : 694be9b900000000 , ddce0ceb00000000,f436b90700000000,
8c40b90700000000, e270b90700000000

Not sure whether it's a valid test scenario or not, but updating just for info.
Project Member

Comment 18 by bugdroid1@chromium.org, Oct 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0c44416f9a7bd9328b93456f7f88f5c26461269

commit f0c44416f9a7bd9328b93456f7f88f5c26461269
Author: fukino <fukino@chromium.org>
Date: Fri Oct 28 10:38:01 2016

Audio player: Throttle concurrent loading of audio metadata.

When the audio player is opened, it starts loading audio metadata of all files
in the same directory.
This can result in running out of the limit for open file descriptors.
This CL throttles the metadata loading, limiting the number of open files up to 25.

BUG= 654769 
TEST=manually tested on a folder which has 1500 mp3 files (took 30 seconds to load all metadata on chell).
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2456153002
Cr-Commit-Position: refs/heads/master@{#428329}

[modify] https://crrev.com/f0c44416f9a7bd9328b93456f7f88f5c26461269/ui/file_manager/audio_player/js/audio_player.js

Re:#17 avkodipelli@,
It sounds a different issue.
Could you file a separate issue for it? PDF preview folks will be able to look into it.
Labels: -M-55 -ReleaseBlock-Stable M-56
Status: Fixed (was: Started)
Ping avkodipelli@ for comment #19.

Removing RB label as this is not a regression, and marking this as Fixed as the audio player issue was gone on ToT.
Does this mean the fix is available or is it coming out in the next chrome
update?
The fix is coming with Chrome 56.
I'm sorry for keep you waiting.
LOL, no prob. I'll survive.
Status: Verified (was: Fixed)
Verified on 8980.0.0/56.0.2915.0.

Sign in to add a comment