Credit Card infobar metric does not differentiate between local save and card upload |
||
Issue descriptionThe histogram Autofill.CreditCardInfoBar [1] does not differentiate between a local save and a card upload, which means that the metric is very hard to analyze. However, that state is available in autofill_save_card_infobar_delegate_mobile.cc (via the |upload_| boolean). Therefore it should be easy to log two new histograms, Autofill.CreditCardInfoBar.Local and Autofill.CreditCardInfoBar.Server, with the same values (ignored, shown, accepted, etc.) based on the value of |upload_|. See a recent change that used histogram suffixes [2] and the tests which will need to be updated [3]. [1] https://cs.chromium.org/chromium/src/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc?rcl=0&l=46 [2] https://codereview.chromium.org/2395243002/ [3] https://cs.chromium.org/chromium/src/chrome/browser/autofill/autofill_save_card_infobar_delegate_mobile_unittest.cc?q=CreditCardInfoBar&sq=package:chromium&l=117&dr=C
,
Oct 20 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Oct 20 2016