New issue
Advanced search Search tips

Issue 654739 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 79180



Sign in to add a comment

[css-grid] Intrinsic maximums resolution does not properly update fit-content or auto tracks

Project Member Reported by svil...@igalia.com, Oct 11 2016

Issue description

The step 2.5 in section 12.5 https://drafts.csswg.org/css-grid/#algo-content of the specs sizes tracks with intrinsic max track sizing functions.

Not so long ago there were only two max track sizing functions min-content and max-content (auto was always resolved to max-content). However there were some recent changes that force us to consider 2 new values: auto (which is not internally translated to max-content although it works the same) and specially the newly added fit-content.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62dc3ff33032432888e0f08a2915df0e88b7c19d

commit 62dc3ff33032432888e0f08a2915df0e88b7c19d
Author: svillar <svillar@igalia.com>
Date: Tue Oct 11 17:41:44 2016

[css-grid] Fix intrinsic maximums resolution with fit-content and auto

The step 2.5 in section 12.5 https://drafts.csswg.org/css-grid/#algo-content
of the specs, details how to sizes tracks with intrinsic max track sizing
functions.

Not so long ago there were only two max track sizing functions min-content
and max-content (auto was always resolved to max-content). However there
were some recent changes that force us to consider 2 new values: auto (which
is not internally translated to max-content although it still works the
same) and specially the newly added fit-content.

Some of the new tests are commented because they fail due to
 https://crbug.com/654737  which is about to be fixed.

BUG= 654739 

Review-Url: https://codereview.chromium.org/2411673003
Cr-Commit-Position: refs/heads/master@{#424475}

[add] https://crrev.com/62dc3ff33032432888e0f08a2915df0e88b7c19d/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-intrinsic-maximums-expected.html
[add] https://crrev.com/62dc3ff33032432888e0f08a2915df0e88b7c19d/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-intrinsic-maximums.html
[modify] https://crrev.com/62dc3ff33032432888e0f08a2915df0e88b7c19d/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
[modify] https://crrev.com/62dc3ff33032432888e0f08a2915df0e88b7c19d/third_party/WebKit/Source/core/style/GridTrackSize.h

Comment 2 by r...@igalia.com, Oct 12 2016

Blocking: 79180
Cc: jfernan...@igalia.com r...@igalia.com
Components: Blink>Layout>Grid

Comment 3 by svil...@igalia.com, Oct 20 2016

Status: Fixed (was: Assigned)
Closing

Sign in to add a comment