New issue
Advanced search Search tips

Issue 654731 link

Starred by 1 user
Status: Fixed
Owner:
pastarmovj@chromium.org
Closed: Nov 2016
Cc:
tommycli@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 615738



Sign in to add a comment

Migrate EnabledPlugins and DisabledPlugins to PDF/Flash specific policies.

Project Member Reported by pastarmovj@chromium.org, Oct 11 2016 
Add migration code for the EnabledPlugins and DisabledPlugins policies.

These policies are deprecated in favor of:
- DefaultPluginSettings which dictates if Flash should be avaialable on web pages.
- AlwaysOpenPdfExternally which dictates if the PDF plugin should be used to open PDF files or if they should rather be opened externally.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/231648330ec3ea62f4a238024b6d2e727a16f75c

commit 231648330ec3ea62f4a238024b6d2e727a16f75c
Author: pastarmovj <pastarmovj@chromium.org>
Date: Mon Oct 17 09:23:47 2016

Document deprecated plugin policies as such.

EnabledPlugins, DisabledPlugins and DisabledPluginsExcpetions are
deprecated as part of the general plugins handling framework deprecation
effort.

BUG= 654731 
TEST=none - Documentation only change.

Review-Url: https://codereview.chromium.org/2419043002
Cr-Commit-Position: refs/heads/master@{#425640}

[modify] https://crrev.com/231648330ec3ea62f4a238024b6d2e727a16f75c/components/policy/resources/policy_templates.json
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6c75ce329c9b4f9c925056d583dd9f1ae24a9d7

commit c6c75ce329c9b4f9c925056d583dd9f1ae24a9d7
Author: pastarmovj <pastarmovj@chromium.org>
Date: Mon Oct 17 19:21:10 2016

Add migration code for the EnabledPlugins and DisabledPlugins policies.

These policies are deprecated in favor of:
DefaultPluginSettings (aka. Flash BLOCK/ALLOW)
AlwaysOpenPdfExternally (aka. PDF plugin disabled)

BUG= 654731 
TEST=browser_tests:PolicyPrefIndicator

Review-Url: https://codereview.chromium.org/2410113002
Cr-Commit-Position: refs/heads/master@{#425743}

[modify] https://crrev.com/c6c75ce329c9b4f9c925056d583dd9f1ae24a9d7/chrome/browser/BUILD.gn
[add] https://crrev.com/c6c75ce329c9b4f9c925056d583dd9f1ae24a9d7/chrome/browser/plugins/plugin_policy_handler.cc
[add] https://crrev.com/c6c75ce329c9b4f9c925056d583dd9f1ae24a9d7/chrome/browser/plugins/plugin_policy_handler.h
[modify] https://crrev.com/c6c75ce329c9b4f9c925056d583dd9f1ae24a9d7/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/c6c75ce329c9b4f9c925056d583dd9f1ae24a9d7/chrome/test/data/policy/policy_test_cases.json

Comment 3 by pastarmovj@chromium.org, Oct 20 2016

Labels: -M-55 M-56
Moving to 56 because next to the policies we have to migrate the user prefs as well.

Comment 4 by pastarmovj@chromium.org, Nov 7 2016

Status: Fixed (was: Started)
Migrating the prefs is now tracked in  crbug.com/662002  marking this one as done.
►

Sign in to add a comment