New issue
Advanced search Search tips

Issue 654730 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Whitelist http://chrome.google.com/webstore/download/ for supervised users

Project Member Reported by mamir@chromium.org, Oct 11 2016

Issue description

Whitelist http://chrome.google.com/webstore/download/ for supervised
users because some extension on the Chrome Webstore are downloaded
from there. 

 

Comment 2 by mamir@chromium.org, Oct 11 2016

Status: Fixed (was: Untriaged)

Comment 3 by mamir@chromium.org, Oct 11 2016

Labels: Merge-Request-55

Comment 4 by dimu@chromium.org, Oct 12 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 12 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7927aff94846f49d255ed52e92d76b9e76fe0291

commit 7927aff94846f49d255ed52e92d76b9e76fe0291
Author: Marc Treib <treib@chromium.org>
Date: Wed Oct 12 12:55:11 2016

Whitelisting one more crx download url

BUG= 654730 

Review-Url: https://codereview.chromium.org/2411673002
Cr-Commit-Position: refs/heads/master@{#424414}
(cherry picked from commit e8a03ecf2576dd11aeb1cb59d7aee6c68d13fd81)

Review URL: https://codereview.chromium.org/2419503002 .

Cr-Commit-Position: refs/branch-heads/2883@{#57}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/7927aff94846f49d255ed52e92d76b9e76fe0291/chrome/browser/supervised_user/supervised_user_url_filter.cc
[modify] https://crrev.com/7927aff94846f49d255ed52e92d76b9e76fe0291/chrome/browser/supervised_user/supervised_user_url_filter_unittest.cc

Labels: Needs-Feedback
Status: Assigned (was: Fixed)
http://chrome.google.com/webstore/download/  is loading a blank white page even for normal user.


Comment 7 by mamir@chromium.org, Oct 22 2016

We don't allow this specific URL.
But we allow any url that starts with "http://chrome.google.com/webstore/download/" for supervised users.
The reason is some extension crx files on Chrome Webstore are hosted on this path, and Chrome should be able to download the crx file for supervised users for extensions in the webstore.
Because there is a dedicated mechanism for allowing/disallowing supervised users from using extensions and for that mechanism to work, Chrome should be able to download the crx file.

Status: Verified (was: Assigned)
Thanks @mamir !!

Verified on ChromeOS 8872.19.0, 55.0.2883.22
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7927aff94846f49d255ed52e92d76b9e76fe0291

commit 7927aff94846f49d255ed52e92d76b9e76fe0291
Author: Marc Treib <treib@chromium.org>
Date: Wed Oct 12 12:55:11 2016

Whitelisting one more crx download url

BUG= 654730 

Review-Url: https://codereview.chromium.org/2411673002
Cr-Commit-Position: refs/heads/master@{#424414}
(cherry picked from commit e8a03ecf2576dd11aeb1cb59d7aee6c68d13fd81)

Review URL: https://codereview.chromium.org/2419503002 .

Cr-Commit-Position: refs/branch-heads/2883@{#57}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/7927aff94846f49d255ed52e92d76b9e76fe0291/chrome/browser/supervised_user/supervised_user_url_filter.cc
[modify] https://crrev.com/7927aff94846f49d255ed52e92d76b9e76fe0291/chrome/browser/supervised_user/supervised_user_url_filter_unittest.cc

Comment 10 by dimu@google.com, Nov 4 2016

[Automated comment] removing mislabelled merge-merged-2840

Comment 11 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment