New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 654709 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 429053



Sign in to add a comment

ES3MapBufferRangeTest crashing on Android Lollipop Low-End Tester bot

Project Member Reported by dgn@chromium.org, Oct 11 2016

Issue description

Tests added in:
https://codereview.chromium.org/2399113003

They have been crashing since they have been added:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=gl_tests&tests=ES3MapBufferRangeTest

Example builder link with the failure:
https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Low-end%20Tester/builds/4144/steps/gl_tests

Failure summary:

failures:
ES3MapBufferRangeTest.TexImageAndSubImage3D
ES3MapBufferRangeTest.ReadPixels
ES3MapBufferRangeTest.DrawArraysAndInstanced
ES3MapBufferRangeTest.DrawElementsAndInstanced
ES3MapBufferRangeTest.TransformFeedback
ES3MapBufferRangeTest.TexImageAndSubImage2D

ES3MapBufferRangeTest.DrawArraysAndInstancedUNKNOWN
OK (0 tests)
[CRASH] ES3MapBufferRangeTest.DrawElementsAndInstanced:
[ RUN      ] ES3MapBufferRangeTest.DrawElementsAndInstanced
[ERROR:context_group.cc(390)] ContextGroup::Initialize failed because maximum vertex output components is too small (0, should be 64).
[ CRASHED      ]

(and same thing for all the others.)


Symbolised stack trace:
-----------------------------------------------------

signal 11 (SIGSEGV), code 1, fault addr 0x0 in tid 32762 (st:test_process)
pid: 32762, tid: 32762, name: st:test_process  >>> org.chromium.native_test:test_process <<<
signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0
     r0 00000000  r1 00008b31  r2 000000ff  r3 00000014
     r4 00008b31  r5 b6dfddd4  r6 b89050f8  r7 be9f8790
     r8 be9f8c58  r9 b6dfddd4  sl b89889a0  fp be9f8cf0
     ip a5f6ed00  sp be9f8790  lr a50b7c75  pc a50b7c76

Stack Trace:
  RELADDR   FUNCTION                                                                                                                                                                                        FILE:LINE
  00180c76  GLES2CreateShader+12                                                                                                                                                                            /b/c/b/Android_arm_Builder__dbg_/src/gpu/command_buffer/client/gles2_c_lib_autogen.h:240
  000e78d3  GLTestHelper::CompileShader(unsigned int, char const*)+14                                                                                                                                       /b/c/b/Android_arm_Builder__dbg_/src/gpu/command_buffer/tests/gl_test_utils.cc:90
  000e824b  GLTestHelper::LoadShader(unsigned int, char const*)+22                                                                                                                                          /b/c/b/Android_arm_Builder__dbg_/src/gpu/command_buffer/tests/gl_test_utils.cc:100
  000e846b  GLTestHelper::LoadProgram(char const*, char const*)+14                                                                                                                                          /b/c/b/Android_arm_Builder__dbg_/src/gpu/command_buffer/tests/gl_test_utils.cc:151
  000e056b  gpu::ES3MapBufferRangeTest::SetupSimpleProgram(int*)+22                                                                                                                                         /b/c/b/Android_arm_Builder__dbg_/src/gpu/command_buffer/tests/gl_map_buffer_range_unittest.cc:46
  000e06c3  gpu::ES3MapBufferRangeTest_DrawArraysAndInstanced_Test::TestBody()+66                                                                                                                           /b/c/b/Android_arm_Builder__dbg_/src/gpu/command_buffer/tests/gl_map_buffer_range_unittest.cc:97
  0093c62b  testing::Test::Run()+106                                                                                                                                                                        /b/c/b/Android_arm_Builder__dbg_/src/testing/gtest/src/gtest.cc:2475
  0093c769  testing::TestInfo::Run()+240                                                                                                                                                                    /b/c/b/Android_arm_Builder__dbg_/src/testing/gtest/src/gtest.cc:2656
  0093c7f5  testing::TestCase::Run()+112                                                                                                                                                                    /b/c/b/Android_arm_Builder__dbg_/src/testing/gtest/src/gtest.cc:2774
  0093f469  testing::internal::UnitTestImpl::RunAllTests()+440                                                                                                                                              /b/c/b/Android_arm_Builder__dbg_/src/testing/gtest/src/gtest.cc:4647
  v------>  bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)  /b/c/b/Android_arm_Builder__dbg_/src/testing/gtest/src/gtest.cc:2458
  009389b1  testing::UnitTest::Run()+96                                                                                                                                                                     /b/c/b/Android_arm_Builder__dbg_/src/testing/gtest/src/gtest.cc:4258
  v------>  RUN_ALL_TESTS()                                                                                                                                                                                 /b/c/b/Android_arm_Builder__dbg_/src/testing/gtest/include/gtest/gtest.h:2237
  0091d6f1  base::TestSuite::Run()+84                                                                                                                                                                       /b/c/b/Android_arm_Builder__dbg_/src/base/test/test_suite.cc:246
  000e8883  (anonymous namespace)::RunHelper(base::TestSuite*)+130                                                                                                                                          /b/c/b/Android_arm_Builder__dbg_/src/gpu/command_buffer/tests/gl_tests_main.cc:41
  00929b31  base::internal::RunMixin<base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> >::Run() const+72                                                                   /b/c/b/Android_arm_Builder__dbg_/src/base/callback.h:64
  v------>  LaunchUnitTestsInternal                                                                                                                                                                         /b/c/b/Android_arm_Builder__dbg_/src/base/test/launcher/unit_test_launcher.cc:186
  00929eb9  base::LaunchUnitTestsSerially(int, char**, base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&)+48                                                        /b/c/b/Android_arm_Builder__dbg_/src/base/test/launcher/unit_test_launcher.cc:469
  000b61c7  main+122                                                                                                                                                                                        /b/c/b/Android_arm_Builder__dbg_/src/gpu/command_buffer/tests/gl_tests_main.cc:59
  v------>  RunTests                                                                                                                                                                                        /b/c/b/Android_arm_Builder__dbg_/src/testing/android/native_test/native_test_launcher.cc:136
  008f867b  Java_org_chromium_native_1test_NativeTest_nativeRunTests+650                                                                                                                                    /b/c/b/Android_arm_Builder__dbg_/src/out/Debug/gen/testing/android/native_test/native_test_jni_headers/testing/jni/NativeTest_jni.h:56
  0001d4d1  <unknown>                                                                                                                                                                                       /data/dalvik-cache/arm/data@app@org.chromium.native_test-2@base.apk@classes.dex

-----------------------------------------------------
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d0935bd4971f94fddc7c6fdd266bfdfec3e3773

commit 0d0935bd4971f94fddc7c6fdd266bfdfec3e3773
Author: dgn <dgn@chromium.org>
Date: Tue Oct 11 10:05:49 2016

Revert of Add gl tests to make sure when a buffer is unmapped, all access path generates an INVALID_OPERATION. (patchset #4 id:60001 of https://codereview.chromium.org/2399113003/ )

Reason for revert:
The new tests have been crashing since they landed.

Original issue's description:
> Add gl tests to make sure when a buffer is unmapped, all access path generates an INVALID_OPERATION.
>
> BUG= 429053 
> TEST=gl_tests
> R=vmiura@chromium.org
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/7e06f15b71f7194c3761bcd3e1677954e5a9cdc4
> Cr-Commit-Position: refs/heads/master@{#424238}

TBR=vmiura@chromium.org,zmo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 429053 , 654709 

Review-Url: https://codereview.chromium.org/2410023002
Cr-Commit-Position: refs/heads/master@{#424398}

[modify] https://crrev.com/0d0935bd4971f94fddc7c6fdd266bfdfec3e3773/gpu/BUILD.gn
[modify] https://crrev.com/0d0935bd4971f94fddc7c6fdd266bfdfec3e3773/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/0d0935bd4971f94fddc7c6fdd266bfdfec3e3773/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc
[modify] https://crrev.com/0d0935bd4971f94fddc7c6fdd266bfdfec3e3773/gpu/command_buffer/service/program_manager.cc
[modify] https://crrev.com/0d0935bd4971f94fddc7c6fdd266bfdfec3e3773/gpu/command_buffer/service/program_manager.h
[modify] https://crrev.com/0d0935bd4971f94fddc7c6fdd266bfdfec3e3773/gpu/command_buffer/service/program_manager_unittest.cc
[modify] https://crrev.com/0d0935bd4971f94fddc7c6fdd266bfdfec3e3773/gpu/command_buffer/service/transform_feedback_manager.cc
[modify] https://crrev.com/0d0935bd4971f94fddc7c6fdd266bfdfec3e3773/gpu/command_buffer/service/transform_feedback_manager.h
[delete] https://crrev.com/aedea0a3d707335de960de84d5ebd05a235733ca/gpu/command_buffer/tests/gl_map_buffer_range_unittest.cc
[modify] https://crrev.com/0d0935bd4971f94fddc7c6fdd266bfdfec3e3773/gpu/command_buffer/tests/gl_program_unittest.cc
[modify] https://crrev.com/0d0935bd4971f94fddc7c6fdd266bfdfec3e3773/gpu/command_buffer/tests/gl_test_utils.cc
[modify] https://crrev.com/0d0935bd4971f94fddc7c6fdd266bfdfec3e3773/gpu/command_buffer/tests/gl_test_utils.h

Comment 2 by kbr@chromium.org, Oct 11 2016

Labels: -OS-Linux -Pri-1 Pri-2
Summary: ES3MapBufferRangeTest crashing on Android Lollipop Low-End Tester bot (was: ES3MapBufferRangeTest crashing on the bots.)
To clarify: these tests were crashing on the Android Lollipop Low-End Tester and no other bots?

If that's true we should just skip these tests on that configuration. The OS is obsolete and the graphics driver is surely buggy.

Comment 3 by zmo@chromium.org, Oct 11 2016

Cc: kbr@chromium.org vmi...@chromium.org
It's surprising it's the CompileShader that's causing the crash.  The shaders I used in these tests are just regular very simple shaders.

Comment 4 by dgn@chromium.org, Oct 11 2016

Yes, they were passing for example on Lollipop Phone Tester.

Comment 5 by zmo@chromium.org, Oct 11 2016

ContextGroup::Initialize failed because maximum vertex output components is too small (0, should be 64).

So the driver couldn't support ES3 at all.  I should have a check in the tests and bypass them if the driver isn't ES3 capable. 
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/444e085edc12c25ef74e34c5b259667fcfeb81f3

commit 444e085edc12c25ef74e34c5b259667fcfeb81f3
Author: zmo <zmo@chromium.org>
Date: Wed Oct 12 01:19:32 2016

[Reland] Add gl tests to make sure when a buffer is unmapped, all access path generates an INVALID_OPERATION.

Original reviewed CL: http://crrev.com/2399113003#ps60001
Reverted in https://codereview.chromium.org/2410023002/

BUG= 429053 , 654709 
TEST=gl_tests
R=vmiura@chromium.org

patch from issue 2399113003 at patchset 60001 ()
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2410343002
Cr-Commit-Position: refs/heads/master@{#424630}

[modify] https://crrev.com/444e085edc12c25ef74e34c5b259667fcfeb81f3/gpu/BUILD.gn
[modify] https://crrev.com/444e085edc12c25ef74e34c5b259667fcfeb81f3/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/444e085edc12c25ef74e34c5b259667fcfeb81f3/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc
[modify] https://crrev.com/444e085edc12c25ef74e34c5b259667fcfeb81f3/gpu/command_buffer/service/program_manager.cc
[modify] https://crrev.com/444e085edc12c25ef74e34c5b259667fcfeb81f3/gpu/command_buffer/service/program_manager.h
[modify] https://crrev.com/444e085edc12c25ef74e34c5b259667fcfeb81f3/gpu/command_buffer/service/program_manager_unittest.cc
[modify] https://crrev.com/444e085edc12c25ef74e34c5b259667fcfeb81f3/gpu/command_buffer/service/transform_feedback_manager.cc
[modify] https://crrev.com/444e085edc12c25ef74e34c5b259667fcfeb81f3/gpu/command_buffer/service/transform_feedback_manager.h
[add] https://crrev.com/444e085edc12c25ef74e34c5b259667fcfeb81f3/gpu/command_buffer/tests/gl_map_buffer_range_unittest.cc
[modify] https://crrev.com/444e085edc12c25ef74e34c5b259667fcfeb81f3/gpu/command_buffer/tests/gl_program_unittest.cc
[modify] https://crrev.com/444e085edc12c25ef74e34c5b259667fcfeb81f3/gpu/command_buffer/tests/gl_test_utils.cc
[modify] https://crrev.com/444e085edc12c25ef74e34c5b259667fcfeb81f3/gpu/command_buffer/tests/gl_test_utils.h

Comment 7 by zmo@chromium.org, Oct 14 2016

Status: Fixed (was: Assigned)

Sign in to add a comment