NPE in CustomTabsService#warmup() |
|||||||
Issue descriptionNullPointerException is thrown on some devices from warmup(). This comes from internal crash reports from AGSA (bug 31861380 in the internal bugtracker). Unfortunately, since the exception is re-thrown by Parcel.java on the GSA side, the Chrome stack trace is not available in the GSA bug reports.
,
Oct 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f974fe4e5a32803b83592a014a82db683cb485f7 commit f974fe4e5a32803b83592a014a82db683cb485f7 Author: lizeb <lizeb@chromium.org> Date: Tue Oct 11 11:56:33 2016 customtabs: Add paranoia to isCallerForegroundOrSelf() due to NPEs in the wild. We have a number of NPEs reported from devices in the wild. Unfortunately, we only know that they happen on L pre-MR1, and from warmup(). This commits adds null checks to prevent these from crashing the client (reported by GSA). BUG= 654705 Review-Url: https://codereview.chromium.org/2404183004 Cr-Commit-Position: refs/heads/master@{#424406} [modify] https://crrev.com/f974fe4e5a32803b83592a014a82db683cb485f7/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
,
Oct 12 2016
Requesting a merge to M55. Rationale: crash visible to users.
,
Oct 12 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d5357e02cda8ed82b7788b76e036937a329460f commit 1d5357e02cda8ed82b7788b76e036937a329460f Author: Benoit Lize <lizeb@chromium.org> Date: Wed Oct 12 14:05:15 2016 customtabs: Add paranoia to isCallerForegroundOrSelf() due to NPEs in the wild. We have a number of NPEs reported from devices in the wild. Unfortunately, we only know that they happen on L pre-MR1, and from warmup(). This commits adds null checks to prevent these from crashing the client (reported by GSA). BUG= 654705 Review-Url: https://codereview.chromium.org/2404183004 Cr-Commit-Position: refs/heads/master@{#424406} (cherry picked from commit f974fe4e5a32803b83592a014a82db683cb485f7) Review URL: https://codereview.chromium.org/2415573002 . Cr-Commit-Position: refs/branch-heads/2883@{#59} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/1d5357e02cda8ed82b7788b76e036937a329460f/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
,
Oct 17 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d5357e02cda8ed82b7788b76e036937a329460f commit 1d5357e02cda8ed82b7788b76e036937a329460f Author: Benoit Lize <lizeb@chromium.org> Date: Wed Oct 12 14:05:15 2016 customtabs: Add paranoia to isCallerForegroundOrSelf() due to NPEs in the wild. We have a number of NPEs reported from devices in the wild. Unfortunately, we only know that they happen on L pre-MR1, and from warmup(). This commits adds null checks to prevent these from crashing the client (reported by GSA). BUG= 654705 Review-Url: https://codereview.chromium.org/2404183004 Cr-Commit-Position: refs/heads/master@{#424406} (cherry picked from commit f974fe4e5a32803b83592a014a82db683cb485f7) Review URL: https://codereview.chromium.org/2415573002 . Cr-Commit-Position: refs/branch-heads/2883@{#59} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/1d5357e02cda8ed82b7788b76e036937a329460f/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840 |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by lizeb@chromium.org
, Oct 11 2016