New issue
Advanced search Search tips

Issue 654684 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature



Sign in to add a comment

Support ARC contents with externalfile: URL

Project Member Reported by hashimoto@chromium.org, Oct 11 2016

Issue description

Currently Chrome cannot access contents managed by ARC if a file is not accessible to the chronos user.
To make it possible to handle any intents with Chrome, we should fix this by letting Chrome access ARC contents via externalfile: URL.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc8994de1b388e468d8b1240d6b150d313fd84d9

commit bc8994de1b388e468d8b1240d6b150d313fd84d9
Author: hashimoto <hashimoto@chromium.org>
Date: Wed Oct 12 04:25:33 2016

Add ARC contents filesystem type

This filesystem type will be used to support ARC contents with externalfile: URL.
Chrome will be able to use externalfile: URLs to access ARC contents.

BUG= 654684 

Review-Url: https://codereview.chromium.org/2405193002
Cr-Commit-Position: refs/heads/master@{#424666}

[modify] https://crrev.com/bc8994de1b388e468d8b1240d6b150d313fd84d9/storage/browser/fileapi/file_system_context.cc
[modify] https://crrev.com/bc8994de1b388e468d8b1240d6b150d313fd84d9/storage/common/fileapi/file_system_types.h
[modify] https://crrev.com/bc8994de1b388e468d8b1240d6b150d313fd84d9/storage/common/fileapi/file_system_util.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 13 2016

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 21 2016

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a53e7e8054ac086bec20a1c77b543b204d57ba90

commit a53e7e8054ac086bec20a1c77b543b204d57ba90
Author: hashimoto <hashimoto@chromium.org>
Date: Wed Oct 26 06:30:47 2016

arc: Register ARC content file system

Add ARC delegate to chromeos::FileSystemBackend.
Add ARC content file system as an external file URL type.
Add ArcContentFileSystemService which is responsible to register the file system.

File system implementation (in chrome/browser/chromeos/arc/fileapi) is empty yet.
It'll be added later.

BUG= 654684 
TBR=sky@chromium.org for platform_util_unittest.cc

Review-Url: https://codereview.chromium.org/2450713002
Cr-Commit-Position: refs/heads/master@{#427609}

[modify] https://crrev.com/a53e7e8054ac086bec20a1c77b543b204d57ba90/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/a53e7e8054ac086bec20a1c77b543b204d57ba90/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/a53e7e8054ac086bec20a1c77b543b204d57ba90/chrome/browser/chromeos/arc/arc_service_launcher.cc
[add] https://crrev.com/a53e7e8054ac086bec20a1c77b543b204d57ba90/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_service.cc
[add] https://crrev.com/a53e7e8054ac086bec20a1c77b543b204d57ba90/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_service.h
[modify] https://crrev.com/a53e7e8054ac086bec20a1c77b543b204d57ba90/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_url_util.cc
[modify] https://crrev.com/a53e7e8054ac086bec20a1c77b543b204d57ba90/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_url_util.h
[modify] https://crrev.com/a53e7e8054ac086bec20a1c77b543b204d57ba90/chrome/browser/chromeos/fileapi/external_file_url_util.cc
[modify] https://crrev.com/a53e7e8054ac086bec20a1c77b543b204d57ba90/chrome/browser/chromeos/fileapi/file_system_backend.cc
[modify] https://crrev.com/a53e7e8054ac086bec20a1c77b543b204d57ba90/chrome/browser/chromeos/fileapi/file_system_backend.h
[modify] https://crrev.com/a53e7e8054ac086bec20a1c77b543b204d57ba90/chrome/browser/chromeos/fileapi/file_system_backend_unittest.cc
[modify] https://crrev.com/a53e7e8054ac086bec20a1c77b543b204d57ba90/chrome/browser/platform_util_unittest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2eb325852a4e5e6509de26200b35be3ff85f8c27

commit 2eb325852a4e5e6509de26200b35be3ff85f8c27
Author: hashimoto <hashimoto@chromium.org>
Date: Tue Nov 08 21:51:48 2016

arc: Make IntentHelper::OpenFileToRead's return value nullable

Version number is not changed as this method has not been implemented by
Android side yet.

BUG= 654684 

Review-Url: https://codereview.chromium.org/2485043003
Cr-Commit-Position: refs/heads/master@{#430726}

[modify] https://crrev.com/2eb325852a4e5e6509de26200b35be3ff85f8c27/components/arc/common/intent_helper.mojom

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2eb325852a4e5e6509de26200b35be3ff85f8c27

commit 2eb325852a4e5e6509de26200b35be3ff85f8c27
Author: hashimoto <hashimoto@chromium.org>
Date: Tue Nov 08 21:51:48 2016

arc: Make IntentHelper::OpenFileToRead's return value nullable

Version number is not changed as this method has not been implemented by
Android side yet.

BUG= 654684 

Review-Url: https://codereview.chromium.org/2485043003
Cr-Commit-Position: refs/heads/master@{#430726}

[modify] https://crrev.com/2eb325852a4e5e6509de26200b35be3ff85f8c27/components/arc/common/intent_helper.mojom

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fd6d1e812d0848c8cf817da160664e548ba3a87

commit 4fd6d1e812d0848c8cf817da160664e548ba3a87
Author: hashimoto <hashimoto@chromium.org>
Date: Wed Nov 16 07:16:02 2016

arc: Convert content: and file: URLs from ARC to externalfile: URLs

BUG= 654684 

Review-Url: https://codereview.chromium.org/2464333004
Cr-Commit-Position: refs/heads/master@{#432415}

[modify] https://crrev.com/4fd6d1e812d0848c8cf817da160664e548ba3a87/chrome/browser/ui/ash/chrome_shell_delegate.cc

Labels: M-56
Status: Fixed (was: Started)
How to test:
 1. Prepare a PDF file under Downloads directory.
 2. Launch Android's Settings app.
 3. Storage -> Explore -> Download
 4. Open the PDF file with Chrome.
Status: Verified (was: Fixed)

Comment 14 by ehdeo...@gmail.com, Jun 23 2017

Hi. I checked externalfile access on R59.
When access by setting app, the function is working well.

However when i open some image file from android file manager app, i can only see broken text string in chrome browser.

Please see attached capture file.
Thanks.


Screenshot 2017-06-23 at 5.00.31 PM.png
714 KB View Download
ehdeoddl@, thank you for reporting.
It seems the issue is same as  issue 704701  which is fixed in M61.
Please wait for your device to get updated to M61.

Comment 16 by ehdeo...@gmail.com, Jun 23 2017

hashimoto@, Thanks for fast and kild reply.
I confirm that this issue is fixed in R61

Thkans!

Sign in to add a comment