New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 654674 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Long OOO (go/where-is-mgiuca)
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

beforeinstallprompt event should have attribute handler version (window.onbeforeinstallprompt)

Project Member Reported by mgiuca@chromium.org, Oct 11 2016

Issue description

Version: 56
OS: All

What steps will reproduce the problem?
(1) Add window.onbeforeinstallprompt = <function>
(2) Set up as a PWA (manifest, etc).
(3) Visit site.

What is the expected output?
window.onbeforeinstallprompt is called when Chrome tries to prompt to install.

What do you see instead?
It is ignored.

Note: You can use window.addEventListener('beforeinstallprompt') for this purpose, but the attribute version (window.onbeforeinstallprompt) doesn't work. This was intentional but it looks like the upcoming spec for beforeinstallprompt is going to require this.
 

Comment 1 by mgiuca@chromium.org, Oct 11 2016

Status: Started (was: Assigned)
I have the infrastructure for this set up in my upcoming appinstalled CL (https://codereview.chromium.org/2379923002/diff/340001/third_party/WebKit/Source/core/frame/WindowInstallation.idl), so I will take care of this at the same time.
Components: UI>Browser>WebAppInstalls
Matt, is this done?

Sign in to add a comment