Shelf stays hidden with no windows open after opening and closing launcher |
||||||
Issue descriptionGoogle Chrome 55.0.2878.0 (Official Build) dev (64-bit) Platform 8861.0.0 (Official Build) dev-channel samus What steps will reproduce the problem? (1) Set shelf to auto-hide (2) Close all browser windows. Note shelf is visible. (3) Click app list button to show launcher. Shelf is still visible. (Unclear if this is expected behavior.) (4) Click outside the launcher. Launcher window closes. What is the expected output? Shelf stays visible, because no windows are open. What do you see instead? Shelf disappears. The screen is entirely empty. (Note: This is with material design flags at default.)
,
Nov 30 2016
Unrelated to material design changes, and doubtful I would be able to get to this any time soon.
,
Nov 30 2016
This still repros on 56.0.2905.0 on device, and on ToT r435011 on Linux desktop. The problem goes away when I run with --ash-md=disabled. There is another problem, possibly related. Sometimes clicking on the app list button does not spawn the app list. I cannot reliably reproduce this. msw, do you have time to look at this? If not, just assign it to me and I'll dig in.
,
Nov 30 2016
I can repro, I'll take a look. FYI, I found it still repros with --ash-md=disabled...
,
Dec 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f05a6730ca4ecdfe336276f0f96d33c2aeb028be commit f05a6730ca4ecdfe336276f0f96d33c2aeb028be Author: msw <msw@chromium.org> Date: Thu Dec 01 04:51:31 2016 Fix shelf auto-hide calculation for app-list visibility. AppListButton tracks per-display [target] visibility. (sets a new flag on Shown/Dismissed callbacks) Check widget/button state, not global shell state. Ignore dismissed app-list windows that are animating closed. Fix a ShelfLayoutManager test to actually catch this. BUG= 654661 TEST=Shelf stays visible when the app-list is hidden. R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2534953006 Cr-Commit-Position: refs/heads/master@{#435554} [modify] https://crrev.com/f05a6730ca4ecdfe336276f0f96d33c2aeb028be/ash/app_list/app_list_presenter_delegate.cc [modify] https://crrev.com/f05a6730ca4ecdfe336276f0f96d33c2aeb028be/ash/common/shelf/app_list_button.cc [modify] https://crrev.com/f05a6730ca4ecdfe336276f0f96d33c2aeb028be/ash/common/shelf/app_list_button.h [modify] https://crrev.com/f05a6730ca4ecdfe336276f0f96d33c2aeb028be/ash/common/shelf/shelf_layout_manager.cc [modify] https://crrev.com/f05a6730ca4ecdfe336276f0f96d33c2aeb028be/ash/common/shelf/shelf_widget.cc [modify] https://crrev.com/f05a6730ca4ecdfe336276f0f96d33c2aeb028be/ash/common/shelf/shelf_widget.h [modify] https://crrev.com/f05a6730ca4ecdfe336276f0f96d33c2aeb028be/ash/shelf/shelf_layout_manager_unittest.cc
,
Dec 1 2016
,
Dec 1 2016
,
Dec 14 2016
Verified on ChromeOS 9083.0.0, 57.0.2950.0 |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by abodenha@chromium.org
, Oct 11 2016Owner: tdander...@chromium.org
Status: Assigned (was: Untriaged)