Issue 654640 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	ssid@chromium.org
Closed:	Nov 2016
Cc:	█ mariakho...@chromium.org █ dskiba@chromium.org primiano@chromium.org █ picksi@chromium.org
Components:	Internals>Instrumentation>Memory
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	Bug
Hotlist-MemoryInfra

MemoryInfra: Skia bitmaps in browser are not reported in memory-infra

Project Member Reported by ssid@chromium.org, Oct 11 2016

Issue description

Background context:go/memory-infra: memory profiling in chrome://tracing

UI uses memory for bitmaps in browser that are currently not reported in memory-infra.

The memory is allocated by ResourceManager through SkMallocPixelRef. Attached stack trace.

Comment 1 by ssid@chromium.org, Oct 11 2016

	skia_browser_stack.png 66.4 KB View Download

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49a669c8ddfd8a45ab0318798359b9b08d2d9fa8

commit 49a669c8ddfd8a45ab0318798359b9b08d2d9fa8
Author: ssid <ssid@chromium.org>
Date: Fri Oct 14 01:49:41 2016

[tracing] Add memory usage of Android UI resources to memory-infra

Add provider to track memory usage of bitmap resources in browser.

BUG= 654640 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2406103002
Cr-Commit-Position: refs/heads/master@{#425232}

[modify] https://crrev.com/49a669c8ddfd8a45ab0318798359b9b08d2d9fa8/cc/resources/scoped_ui_resource.h
[modify] https://crrev.com/49a669c8ddfd8a45ab0318798359b9b08d2d9fa8/cc/resources/ui_resource_bitmap.h
[modify] https://crrev.com/49a669c8ddfd8a45ab0318798359b9b08d2d9fa8/ui/android/resources/crushed_sprite_resource.cc
[modify] https://crrev.com/49a669c8ddfd8a45ab0318798359b9b08d2d9fa8/ui/android/resources/crushed_sprite_resource.h
[modify] https://crrev.com/49a669c8ddfd8a45ab0318798359b9b08d2d9fa8/ui/android/resources/resource_manager_impl.cc
[modify] https://crrev.com/49a669c8ddfd8a45ab0318798359b9b08d2d9fa8/ui/android/resources/resource_manager_impl.h
[modify] https://crrev.com/49a669c8ddfd8a45ab0318798359b9b08d2d9fa8/ui/android/resources/resource_manager_impl_unittest.cc

Comment 3 by ssid@chromium.org, Oct 14 2016

Cc: primiano@chromium.org

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae1e2192c4d9bc962ecc4e0b82a0bd5ba153577c

commit ae1e2192c4d9bc962ecc4e0b82a0bd5ba153577c
Author: ssid <ssid@chromium.org>
Date: Fri Oct 14 21:52:16 2016

[tracing] Whitelist android ResourceManagerImpl dump provider for field trials.

BUG= 654640 
R=primiano@chromium.org

Review-Url: https://codereview.chromium.org/2422483002
Cr-Commit-Position: refs/heads/master@{#425479}

[modify] https://crrev.com/ae1e2192c4d9bc962ecc4e0b82a0bd5ba153577c/base/trace_event/memory_infra_background_whitelist.cc

Comment 5 by ssid@chromium.org, Nov 29 2016

Status: Fixed (was: Untriaged)

Comment 6 by primiano@chromium.org, Jan 4 2017

Components: Internals>Instrumentation>Memory

►

Issue 654640 link

Issue metadata

MemoryInfra: Skia bitmaps in browser are not reported in memory-infra

Issue description

Comment 1 by ssid@chromium.org, Oct 11 2016

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Oct 14 2016

Comment 2 Deleted

Comment 3 by ssid@chromium.org, Oct 14 2016

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Oct 14 2016

Comment 4 Deleted

Comment 5 by ssid@chromium.org, Nov 29 2016

Comment 5 Deleted

Comment 6 by primiano@chromium.org, Jan 4 2017

Comment 6 Deleted

Sign in to add a comment