New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 654638 link

Starred by 2 users
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: Oct 2016
Cc:
dbeam@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 655876



Sign in to add a comment

[Site Settings] Place site settings All sites and Site details behind a flag

Project Member Reported by dschuyler@chromium.org, Oct 11 2016 
In the material design conversion of chrome://settings (chrome://md-settings) the Site settings also started getting some new handy features. These features are still in the works, and we'd like to chose whether to include them in the chrome://md-settings release or release them in a later build.

Comment 1 by dbeam@chromium.org, Oct 11 2016

Labels: -Pri-3 OS-Chrome OS-Linux OS-Mac OS-Windows Pri-1

Comment 2 by dschuyler@chromium.org, Oct 11 2016

Summary: [Site Settings] Place site settings All sites and Site details behind a flag (was: Place site settings All sites and Site details behind a flag)

Comment 3 by lgar...@chromium.org, Oct 14 2016

Blocking: 655876
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2bc8c55e0b4e130cd0f8b9e9dae77c3c0134a42

commit b2bc8c55e0b4e130cd0f8b9e9dae77c3c0134a42
Author: dschuyler <dschuyler@chromium.org>
Date: Fri Oct 14 23:03:13 2016

[MD settings] flag to enable site settings All sites and Site details pages

This CL places the pages for All Sites and Site details behind a flag.

BUG= 654638 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2409003002
Cr-Commit-Position: refs/heads/master@{#425503}

[modify] https://crrev.com/b2bc8c55e0b4e130cd0f8b9e9dae77c3c0134a42/chrome/app/generated_resources.grd
[modify] https://crrev.com/b2bc8c55e0b4e130cd0f8b9e9dae77c3c0134a42/chrome/browser/about_flags.cc
[modify] https://crrev.com/b2bc8c55e0b4e130cd0f8b9e9dae77c3c0134a42/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/b2bc8c55e0b4e130cd0f8b9e9dae77c3c0134a42/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/b2bc8c55e0b4e130cd0f8b9e9dae77c3c0134a42/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/b2bc8c55e0b4e130cd0f8b9e9dae77c3c0134a42/chrome/browser/resources/settings/site_settings_page/site_settings_page.html
[modify] https://crrev.com/b2bc8c55e0b4e130cd0f8b9e9dae77c3c0134a42/chrome/browser/resources/settings/site_settings_page/site_settings_page.js
[modify] https://crrev.com/b2bc8c55e0b4e130cd0f8b9e9dae77c3c0134a42/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/b2bc8c55e0b4e130cd0f8b9e9dae77c3c0134a42/chrome/common/chrome_switches.cc
[modify] https://crrev.com/b2bc8c55e0b4e130cd0f8b9e9dae77c3c0134a42/chrome/common/chrome_switches.h
[modify] https://crrev.com/b2bc8c55e0b4e130cd0f8b9e9dae77c3c0134a42/chrome/test/data/webui/settings/site_list_tests.js
[modify] https://crrev.com/b2bc8c55e0b4e130cd0f8b9e9dae77c3c0134a42/tools/metrics/histograms/histograms.xml

Comment 5 by dschuyler@chromium.org, Oct 17 2016

Status: Fixed (was: Started)
►

Sign in to add a comment