Integer-overflow in av_add_stable |
||||||
Issue descriptionDetailed report: https://cluster-fuzz.appspot.com/testcase?key=5310534440452096 Fuzzer: ochang_search_index_mutator Job Type: linux_ubsan_chrome Platform Id: linux Crash Type: Integer-overflow Crash Address: Crash State: av_add_stable compute_pkt_fields read_frame_internal Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=370022:370027 Minimized Testcase (5.81 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97HYb2VDXqVnBT6t872cpj1PDIIgt941AGnMJv9OSvBkZHs7QwNxCv5PpRoHs_9kZyZriUpqgr25T0Fu-SwRI5w9Z6vu63cSNd3806oF5JkuGe4LcuMy4WI8jN30tAYpkAMvsSV2XSjBUu7Q0Fxg-99J2Va0A?testcase_id=5310534440452096 Issue manually filed by: mummareddy See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
,
Oct 11 2016
,
Oct 18 2016
,
Nov 22 2016
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 23 2017
This looks like a recently detected issue that appears to have been in FFmpeg for quite a while - Dale, can you take a look during your ffmpeg roll for M-64?
,
Oct 23 2017
This was detected in Oct of 2016 so I don't think it's recent :) I will take a look though.
,
Oct 23 2017
Oops I saw Oct and thought this year when re-assigning. I'm not sure how this slipped my filters until now.
,
Oct 23 2017
I double-checked the list of UBsan issues I had sent to Niedermayer later in 2016 but couldn't find any reference to this. Again, not sure how this slipped through my filters. Thanks for taking a look.
,
Nov 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/third_party/ffmpeg/+/732525a160bc98935b757d6e13b8a0115e62d929 commit 732525a160bc98935b757d6e13b8a0115e62d929 Author: Dale Curtis <dalecurtis@chromium.org> Date: Sat Nov 18 00:25:20 2017 Disable unused ogg codec parsers; they have bugs we don't care about. Ogg has parsers for a bunch of codecs we don't care about. Long ago we also disabled these, but we re-enabled them because it didn't matter at the time. We would just fail during demuxing instead; but now it seems there are bugs in these parsers, so disable them to avoid bringing their issues along. The issue in this case is bad timestamps, but there's no good fix for this in the speex code that I can see, so it's simpler to just blanket disable. BUG= 654612 TEST=media_unittests still pass Change-Id: I4f4e683a338dafe2df11ade6efca57ad0498f974 Reviewed-on: https://chromium-review.googlesource.com/777969 Reviewed-by: Dan Sanders <sandersd@chromium.org> [modify] https://crrev.com/732525a160bc98935b757d6e13b8a0115e62d929/CREDITS.chromium [modify] https://crrev.com/732525a160bc98935b757d6e13b8a0115e62d929/chromium/scripts/generate_gn.py [modify] https://crrev.com/732525a160bc98935b757d6e13b8a0115e62d929/libavformat/oggdec.c [modify] https://crrev.com/732525a160bc98935b757d6e13b8a0115e62d929/ffmpeg_generated.gni [modify] https://crrev.com/732525a160bc98935b757d6e13b8a0115e62d929/chromium/patches/README
,
Nov 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aea3d2d4d8d304df1a029ef83d248508073bd066 commit aea3d2d4d8d304df1a029ef83d248508073bd066 Author: Dale Curtis <dalecurtis@chromium.org> Date: Sat Nov 18 06:56:26 2017 Roll ffmpeg DEPS and fix additional ubsan issues. This change enables AV_EF_EXPLODE such that all serious errors encountered during demuxing are fatal. Previously ffmpeg would try to ignore these in some cases; leading to ubsan or other issues. Specifically crbug.com/698524 and crbug.com/710791 . Due to the removal of the speex parser from ogg, there is one test that needs updating with the roll too. https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/1e816bccb5ff..252244150ad7 $ git log 1e816bccb..252244150 --date=short --no-merges --format='%ad %ae %s' 2017-11-17 dalecurtis [mpeg4video] Fix undefined shift on assumed 8-bit input. 2017-11-17 dalecurtis Disable unused ogg codec parsers; they have bugs we don't care about. 2017-11-17 dalecurtis Use ff_thread_once for fixed, float table init. 2017-11-17 dalecurtis Fixup some patches messages. 2017-11-17 dalecurtis [mov] Fix leak of frame_duration_buffer in mov_fix_index(). 2017-11-17 dalecurtis Prevent undefined shift with wrap_bits >= 63. 2017-11-15 hubbe avformat/mov: Check size of STSC allocation 2017-11-17 jstebbins [PATCH] lavf/mov: don't read outside frag_index bounds Created with: roll-dep src/third_party/ffmpeg BUG= 786269 , 782074 , 783459 , 784159 , 654612 , 779924 , 710791 , 698524 TEST=security test cases no longer fail. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ibbf3c32080705d6484682351a351663c51a7f752 Reviewed-on: https://chromium-review.googlesource.com/777408 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#517709} [modify] https://crrev.com/aea3d2d4d8d304df1a029ef83d248508073bd066/DEPS [modify] https://crrev.com/aea3d2d4d8d304df1a029ef83d248508073bd066/media/filters/ffmpeg_demuxer_unittest.cc [modify] https://crrev.com/aea3d2d4d8d304df1a029ef83d248508073bd066/media/filters/ffmpeg_glue.cc
,
Nov 19 2017
ClusterFuzz has detected this issue as fixed in range 517698:517712. Detailed report: https://clusterfuzz.com/testcase?key=5310534440452096 Fuzzer: ochang_search_index_mutator Job Type: linux_ubsan_chrome Platform Id: linux Crash Type: Integer-overflow Crash Address: Crash State: av_add_stable compute_pkt_fields read_frame_internal Sanitizer: undefined (UBSAN) Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=370022:370027 Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=517698:517712 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5310534440452096 See https://github.com/google/clusterfuzz-tools for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Nov 19 2017
ClusterFuzz testcase 5310534440452096 is verified as fixed, so closing issue as verified. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by mummare...@chromium.org
, Oct 10 2016Labels: M-54 Te-Logged
Owner: wolenetz@chromium.org
Status: Assigned (was: Untriaged)