New issue
Advanced search Search tips

Issue 654609 link

Starred by 2 users
Status: Fixed
Owner:
kainino@chromium.org
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 295792



Sign in to add a comment

Test and handle getBufferSubData/Async error case when transform feedback is active

Project Member Reported by kainino@chromium.org, Oct 10 2016 
We currently implement but *are not testing* this error case in getBufferSubDataAsync. It may not be implemented at all in getBufferSubData.

> If target is TRANSFORM_FEEDBACK_BUFFER, and any transform feedback object is currently active, an INVALID_OPERATION error is generated.

Comment 1 by kainino@chromium.org, Oct 10 2016

Summary: Test and getBufferSubData/Async error case when transform feedback is active (was: Test and getBufferSubData/Async error case when transform feedback )

Comment 2 by kainino@chromium.org, Oct 13 2016

Blockedon: 616554
Status: Started (was: Assigned)
Summary: Test and handle getBufferSubData/Async error case when transform feedback is active (was: Test and getBufferSubData/Async error case when transform feedback is active)
Tests added.

getBufferSubData:
https://github.com/KhronosGroup/WebGL/pull/2097

getBufferSubDataAsync:
https://github.com/KhronosGroup/WebGL/pull/2079

Fixed in:
https://codereview.chromium.org/2379203002

Comment 3 by kainino@chromium.org, Oct 19 2016

Status: Fixed (was: Started)

Comment 4 by kainino@chromium.org, Oct 19 2016

Blockedon: -616554
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/884e8e8ad9cf667829d80f4bd222a0369baa088b

commit 884e8e8ad9cf667829d80f4bd222a0369baa088b
Author: kainino <kainino@chromium.org>
Date: Wed Oct 19 23:34:13 2016

Implement a prototype for the proposed getBufferSubDataAsync entry point specified in this WebGL PR:

https://github.com/KhronosGroup/WebGL/pull/2079

BUG= 616554 
BUG= 654609 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
NOTRY=true

Review-Url: https://chromiumcodereview.appspot.com/2379203002
Cr-Commit-Position: refs/heads/master@{#426335}

[modify] https://crrev.com/884e8e8ad9cf667829d80f4bd222a0369baa088b/content/renderer/webgraphicscontext3d_provider_impl.cc
[modify] https://crrev.com/884e8e8ad9cf667829d80f4bd222a0369baa088b/content/renderer/webgraphicscontext3d_provider_impl.h
[modify] https://crrev.com/884e8e8ad9cf667829d80f4bd222a0369baa088b/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/884e8e8ad9cf667829d80f4bd222a0369baa088b/gpu/GLES2/gl2chromium_autogen.h
[modify] https://crrev.com/884e8e8ad9cf667829d80f4bd222a0369baa088b/gpu/command_buffer/build_gles2_cmd_buffer.py
[modify] https://crrev.com/884e8e8ad9cf667829d80f4bd222a0369baa088b/gpu/command_buffer/client/gles2_c_lib_autogen.h
[modify] https://crrev.com/884e8e8ad9cf667829d80f4bd222a0369baa088b/gpu/command_buffer/client/gles2_cmd_helper_autogen.h
[modify] https://crrev.com/884e8e8ad9cf667829d80f4bd222a0369baa088b/gpu/command_buffer/client/gles2_implementation.cc
[modify] https://crrev.com/884e8e8ad9cf667829d80f4bd222a0369baa088b/gpu/command_buffer/client/gles2_implementation.h
[modify] https://crrev.com/884e8e8ad9cf667829d80f4bd222a0369baa088b/gpu/command_buffer/client/gles2_implementation_autogen.h
[modify] https://crrev.com/884e8e8ad9cf667829d80f4bd222a0369baa088b/gpu/command_buffer/client/gles2_implementation_unittest.cc
[modify] https://crrev.com/884e8e8ad9cf667829d80f4bd222a0369baa088b/gpu/command_buffer/client/gles2_interface.h
[modify] https://crrev.com/884e8e8ad9cf667829d80f4bd222a0369baa088b/gpu/command_buffer/client/gles2_interface_autogen.h
[modify] https://crrev.com/884e8e8ad9cf667829d80f4bd222a0369baa088b/gpu/command_buffer/client/gles2_interface_stub_autogen.h
[modify] https://crrev.com/884e8e8ad9cf667829d80f4bd222a0369baa088b/gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h
[modify] https://crrev.com/884e8e8ad9cf667829d80f4bd222a0369baa088b/gpu/command_buffer/client/gles2_trace_implementation_autogen.h
[modify] https://crrev.com/884e8e8ad9cf667829d80f4bd222a0369baa088b/gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h
[modify] https://crrev.com/884e8e8ad9cf667829d80f4bd222a0369baa088b/gpu/command_buffer/cmd_buffer_functions.txt
[modify] https://crrev.com/884e8e8ad9cf667829d80f4bd222a0369baa088b/gpu/command_buffer/common/gles2_cmd_format_autogen.h
[modify] https://crrev.com/884e8e8ad9cf667829d80f4bd222a0369baa088b/gpu/command_buffer/common/gles2_cmd_format_test_autogen.h
[modify] https://crrev.com/884e8e8ad9cf667829d80f4bd222a0369baa088b/gpu/command_buffer/common/gles2_cmd_ids_autogen.h
[modify] https://crrev.com/884e8e8ad9cf667829d80f4bd222a0369baa088b/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/884e8e8ad9cf667829d80f4bd222a0369baa088b/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers.cc
[modify] https://crrev.com/884e8e8ad9cf667829d80f4bd222a0369baa088b/third_party/WebKit/Source/modules/webgl/DEPS
[modify] https://crrev.com/884e8e8ad9cf667829d80f4bd222a0369baa088b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
[modify] https://crrev.com/884e8e8ad9cf667829d80f4bd222a0369baa088b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h
[modify] https://crrev.com/884e8e8ad9cf667829d80f4bd222a0369baa088b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl
[modify] https://crrev.com/884e8e8ad9cf667829d80f4bd222a0369baa088b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h
[modify] https://crrev.com/884e8e8ad9cf667829d80f4bd222a0369baa088b/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferSoftwareRenderingTest.cpp
[modify] https://crrev.com/884e8e8ad9cf667829d80f4bd222a0369baa088b/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTestHelpers.h
[modify] https://crrev.com/884e8e8ad9cf667829d80f4bd222a0369baa088b/third_party/WebKit/Source/platform/graphics/test/FakeWebGraphicsContext3DProvider.h
[modify] https://crrev.com/884e8e8ad9cf667829d80f4bd222a0369baa088b/third_party/WebKit/public/platform/WebGraphicsContext3DProvider.h
►

Sign in to add a comment