New issue
Advanced search Search tips

Issue 654605 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Add WITHOUT ROWID support to recover.c

Project Member Reported by sh...@chromium.org, Oct 10 2016

Issue description

https://www.sqlite.org/withoutrowid.html

A few years ago SQLite added a feature which can consolidate a non-integer index with the table data in certain cases.  Since Chromium has many dbs in the wild, I haven't really pushed using it.  This CL:
   https://codereview.chromium.org/2390773003/
probably would benefit, though.  The main reason not to go for it is that recover.c doesn't support WITHOUT ROWID, and I'd rather have comprehensive error handling than the modest space savings.

WITHOUT ROWID basically stores index-like data in the table.  recover.c already contains most of the necessary infrastructure, in fact my development client has additional code to do things like decode indices.
 

Comment 1 by sh...@chromium.org, Jun 21 2017

Labels: ShessReview

Comment 2 by jrobb...@google.com, Sep 21 2017

Owner: pwnall@chromium.org

Sign in to add a comment