Expecting un-url-encoded filename when saving text/plain files |
|||||
Issue descriptionChrome Version : 53.0.2785.143 OS Version: OS X 10.11.6, also happening on my linux box URLs (if applicable) : http://storage.googleapis.com/bucketfot.appspot.com/✰✰✰.txt (or really, I guess http://storage.googleapis.com/bucketfot.appspot.com/%E2%9C%B0%E2%9C%B0%E2%9C%B0.txt) Other browsers tested: Add OK or FAIL after other browsers where you have tested this issue: Safari 10: OK What steps will reproduce the problem? 1. Go to http://storage.googleapis.com/bucketfot.appspot.com/✰✰✰.txt 2. command+S to save the file 3. Get a dialog to save %E2%9C%B0%E2%9C%B0%E2%9C%B0.txt What is the expected result? At step 3, get dialog to save ✰✰✰.txt (or maybe even ✰✰✰, but definitely something that isn't encoded) What happens instead of that? Get dialog to save %E2%9C%B0%E2%9C%B0%E2%9C%B0.txt Please provide any additional information below. This happens if the content-type is text/plain, but not if it's image/jpeg. (I was pointed in passing to https://cs.chromium.org/chromium/src/content/browser/web_contents/web_contents_impl.cc?rcl=1476113755&l=2838)
,
Oct 11 2016
The filename is correct if one invokes "Save link as" on the link, but not if one invokes ^S to save.
,
Oct 11 2016
Issue 654593 has been merged into this issue.
,
Oct 12 2016
Able to reproduce the issue on MAC 10.11.6, Windows 10 and Ubuntu 14.04 using chrome reported version #53.0.2785.143 and latest canary #56.0.2888.0 This is a non regression as it is observed from M40, M45 and M50 old builds. Hence, marking it as untriaged to get more inputs from dev team. Thanks,
,
Dec 15 2016
We should investigate decoding this and sanitizing it.
,
Jan 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d4d0fd0973238c92bbd629960eeed5b3481b48c commit 0d4d0fd0973238c92bbd629960eeed5b3481b48c Author: xingliu <xingliu@chromium.org> Date: Tue Jan 10 22:24:52 2017 Decode url in save package download. Save package does not decode the url when the web content has no title. Also add some unit tests for special characters. BUG= 654591 Review-Url: https://codereview.chromium.org/2595753002 Cr-Commit-Position: refs/heads/master@{#442710} [modify] https://crrev.com/0d4d0fd0973238c92bbd629960eeed5b3481b48c/content/browser/download/save_package.cc [modify] https://crrev.com/0d4d0fd0973238c92bbd629960eeed5b3481b48c/content/browser/download/save_package_unittest.cc
,
Jan 19 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by mef@chromium.org
, Oct 11 2016Labels: Hotlist-Google
Status: Untriaged (was: Unconfirmed)