build/android/test_runner.py --gtest_filter_file doesn't support comments or blank lines |
||
Issue descriptionFor parity with -test-launcher-filter-file (see r368343), test_runner.py should also support comments and blank lines in filter files being passed to --gtest_filter_file switch. Without this kind of support, it is difficult to reuse site-per-process filter files (e.g. testing/buildbot/filters/site-per-process.content_browsertests.filter) when running tests on Android.
,
Oct 10 2016
FWIW, I see that filter files under build/android/pylib/gtest/filter *do* contain blank lines and comments starting with '#' character. OTOH, I cannot find references to these files elsewhere in Chromium source code. I think these filter files are not used together with --gtest-filter-file switch (because looking at self._gtest_filter initialization in build/android/pylib/gtest/gtest_test_instance.py I really don't see how it could support blank lines and comments as-is).
,
Oct 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/705aa265b8d39f3b121086030e00986782748e23 commit 705aa265b8d39f3b121086030e00986782748e23 Author: lukasza <lukasza@chromium.org> Date: Tue Oct 11 15:44:10 2016 Tweak --gtest_filter_file switch to support blank lines and comment lines. BUG= 654589 TEST=Manually tried running out/.../bin/run_content_browsertests --gtest-filter-file=$HOME/scratch/file-with-comments-and-blank-lines.txt Review-Url: https://codereview.chromium.org/2405063002 Cr-Commit-Position: refs/heads/master@{#424437} [modify] https://crrev.com/705aa265b8d39f3b121086030e00986782748e23/build/android/pylib/gtest/gtest_test_instance.py
,
Oct 11 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by lukasza@chromium.org
, Oct 10 2016Adding error details below. When I run $ run_content_browsertests -v --gtest-filter-file=testing/buildbot/filters/site-per-process.content_browsertests.filter I get: CommandFailedError: Failed to list tests on any device This error goes away after changes being proposed in https://codereview.chromium.org/2405063002.