New issue
Advanced search Search tips

Issue 654588 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug

Blocked on:
issue 648496

Blocking:
issue 614588
issue 663587



Sign in to add a comment

MD Settings: Runtime errors when using Guest mode

Project Member Reported by dpa...@chromium.org, Oct 10 2016

Issue description

Just loading chrome://md-settings is Guest mode (tried Linux), results in runtime errors (see attachment).
 
guest_mode_errors.png
86.1 KB View Download

Comment 1 by dpa...@chromium.org, Oct 10 2016

Owner: dpa...@chromium.org
Status: Assigned (was: Untriaged)
Started investigating this, because it seems related to https://bugs.chromium.org/p/chromium/issues/detail?id=652666.

Comment 2 by dpa...@chromium.org, Oct 10 2016

Cc: steve...@chromium.org michae...@chromium.org
Status: Available (was: Assigned)
Started with a simple approach of not loading <settings-prefs> when in Guest mode, see [1]. This fixes non-CrOS runtime exceptions.

With [1], in CrOS guest mode, there is still a runtime exception which is caused by calling chrome.settingsPrivate.setDefaultZoomLevel(), which is always erroneously called at startup (this has already been discovered at at  crbug.com/652483 ).

@stevenjb, michaelpg: Is not loading <settings-prefs> the correct approach for guest mode? Un-assigning myself for now.

[1] https://codereview.chromium.org/2406043002
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7577ff2509a7a5d91ec319f12a42dd1acdb1a41f

commit 7577ff2509a7a5d91ec319f12a42dd1acdb1a41f
Author: dpapad <dpapad@chromium.org>
Date: Sat Oct 15 00:41:22 2016

MD Settings: Stop calling chrome.settingsPrivate.setDefaultZoomLevel on startup.

BUG= 652483 , 654588 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2403353002
Cr-Commit-Position: refs/heads/master@{#425519}

[modify] https://crrev.com/7577ff2509a7a5d91ec319f12a42dd1acdb1a41f/chrome/browser/resources/settings/appearance_page/appearance_page.html
[modify] https://crrev.com/7577ff2509a7a5d91ec319f12a42dd1acdb1a41f/chrome/browser/resources/settings/appearance_page/appearance_page.js

Comment 4 by dpa...@chromium.org, Oct 21 2016

Ping @stevenjb @michaelpg, see question at #2.
Blockedon: 648496
<settings-prefs> is required for Chrome OS.
Cc: dpa...@chromium.org
Owner: hcarmona@chromium.org
Blocking: 663587

Comment 9 by dbeam@chromium.org, Nov 17 2016

Blocking: 614588

Comment 10 by dbeam@chromium.org, Nov 17 2016

Labels: OS-Linux OS-Mac OS-Windows
Status: Fixed (was: Available)

Sign in to add a comment