New issue
Advanced search Search tips

Issue 654582 link

Starred by 3 users
Status: Verified
Owner:
steve...@chromium.org
Closed: Dec 2016
Cc:
tbuck...@chromium.org
michae...@chromium.org
steve...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

MD Settings: Runtime errors when dragging display in CrOS settings.

Project Member Reported by dpa...@chromium.org, Oct 10 2016 
Repro:
1) Go to chrome://md-settings/device
2) Click on Display
3) Attempt to drag the display box
4) Observe runtime errors in dev console (see errors attachment).
cros_display.png
172 KB View Download

Comment 1 by tbuck...@chromium.org, Oct 10 2016

Labels: Hotlist-MD-Settings-Device OS-Chrome
Owner: steve...@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by steve...@chromium.org, Oct 14 2016

Labels: M-56

Comment 3 by steve...@chromium.org, Nov 22 2016

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7bd96109dbda7d002e40000915bdc673f0d7e868

commit 7bd96109dbda7d002e40000915bdc673f0d7e868
Author: stevenjb <stevenjb@chromium.org>
Date: Wed Nov 23 21:10:15 2016

MD Settings: Display: Fix runtime error

Do not attempt to find a parent display when there is only one.

BUG= 654582 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2522103002
Cr-Commit-Position: refs/heads/master@{#434247}

[modify] https://crrev.com/7bd96109dbda7d002e40000915bdc673f0d7e868/chrome/browser/resources/settings/device_page/display_layout.js
[modify] https://crrev.com/7bd96109dbda7d002e40000915bdc673f0d7e868/chrome/browser/resources/settings/device_page/layout_behavior.js

Comment 5 by steve...@chromium.org, Nov 23 2016

Status: Fixed (was: Started)

Comment 6 by rookrishna@chromium.org, Dec 6 2016

Labels: Merge-Request-56
Status: Assigned (was: Fixed)
Fixed on TOT need merge to M56

Tested on 56.0.2924.17/9000.18.0

Comment 7 by dimu@chromium.org, Dec 6 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)

Comment 8 by steve...@chromium.org, Dec 6 2016

Status: Fixed (was: Assigned)
We are not shipping MD Settings as the default settings in M56, so no need to merge this.

Comment 9 by rookrishna@chromium.org, Dec 6 2016

Labels: -M-56 -Merge-Approved-56 M-57
Status: Verified (was: Fixed)
►

Sign in to add a comment