New issue
Advanced search Search tips

Issue 654576 link

Starred by 3 users
Status: WontFix
Owner:
wittman@chromium.org
Closed: Dec 10
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Remove unnecessary logging during startup

Project Member Reported by wittman@chromium.org, Oct 10 2016 
The UMA sampling profiler shows that the call of localtime_s by logging::LogMessage::Init forces the load of a supporting library via an eventual call to GetTimeZoneInformation. This is expensive, and responsible for 3.6ms of startup time on average for a recent Win x64 canary, 1.5ms of which occurs before message loop start: https://uma.googleplex.com/p/chrome/callstacks?sid=27da52168b9ee1b728f6d5009bb2d705

We should remove unnecessary logging from startup to defer this overhead as long as possible.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e28a5860367f57a4a769f84f9d4c295b5b92f869

commit e28a5860367f57a4a769f84f9d4c295b5b92f869
Author: wittman <wittman@chromium.org>
Date: Thu Oct 13 16:43:47 2016

Remove unnecessary keybinding logging

This is logging slowing down pre-message-loop startup. The average
slowdown over the whole population is ~620μs, which is significant
considering the vast majority of users likely do not hit this code path.

BUG= 654576 

Review-Url: https://codereview.chromium.org/2407993002
Cr-Commit-Position: refs/heads/master@{#425058}

[modify] https://crrev.com/e28a5860367f57a4a769f84f9d4c295b5b92f869/chrome/browser/extensions/extension_commands_global_registry.cc

Comment 2 by wittman@chromium.org, Dec 10

Status: WontFix (was: Assigned)
In a recent Windows canary logging took just 1.3ms on average during the first 30 seconds of startup on the browser process main thread.
►

Sign in to add a comment