I think this is a good fix for now. In the long term I think it's okay to allow over-panning in this case if we use animation to remove the padding when the toolbar goes away. In the long term I think the approach that minimizes branching of logic is more maintainable...

I'd prefer to keep this behavior long-term as well, unless we can think of a compelling user scenario which requires it.  If there is such a scenario (not counting N behaviors) then we can use the same re-centering mechanism used in the Soft Input Method scenario.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77a6c664de52f6a28910ab585a347ed0f4c2d899

commit 77a6c664de52f6a28910ab585a347ed0f4c2d899
Author: joedow <joedow@chromium.org>
Date: Mon Oct 10 23:32:33 2016

Moving logic for System UI state changes into DesktopCanvas class

Most of the logic for reacting to System UI changes was already in the
DesktopCanvaqs class however there was one boolean check outside of
that.  Instead of adding yet another parameter to the DesktopCanvas
handler method, I now pass the event parameters themselves.  This will
allow future changes to the logic to be made solely in the DesktopCanvas
class.

BUG= 654565 

Review-Url: https://codereview.chromium.org/2410613003
Cr-Commit-Position: refs/heads/master@{#424284}

[modify] https://crrev.com/77a6c664de52f6a28910ab585a347ed0f4c2d899/remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java
[modify] https://crrev.com/77a6c664de52f6a28910ab585a347ed0f4c2d899/remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99f909132e4756059b6414b723beadd72453a71c

commit 99f909132e4756059b6414b723beadd72453a71c
Author: joedow <joedow@chromium.org>
Date: Tue Oct 11 19:11:36 2016

Update DesktopCanvas to allow over-panning when Soft Input Method is present.

My previous change allowed the user to 'over-pan' the desktop image such
that it can be pulled out from under any System UI present.  After using
the feature a bit and tqalking with other folks on the team, I think
this behavior should be restricted to only be allowed when a Soft Input
Method is present.

BUG= 654565 

Review-Url: https://codereview.chromium.org/2411503002
Cr-Commit-Position: refs/heads/master@{#424506}

[modify] https://crrev.com/99f909132e4756059b6414b723beadd72453a71c/remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java

Your change meets the bar and is auto-approved for M55 (branch: 2883)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48c4493746716ffec1fae380abc80583b6fc2326

commit 48c4493746716ffec1fae380abc80583b6fc2326
Author: Joe Downing <joedow@google.com>
Date: Tue Oct 11 22:23:14 2016

Moving logic for System UI state changes into DesktopCanvas class

Most of the logic for reacting to System UI changes was already in the
DesktopCanvaqs class however there was one boolean check outside of
that.  Instead of adding yet another parameter to the DesktopCanvas
handler method, I now pass the event parameters themselves.  This will
allow future changes to the logic to be made solely in the DesktopCanvas
class.

BUG= 654565 

Review-Url: https://codereview.chromium.org/2410613003
Cr-Commit-Position: refs/heads/master@{#424284}
(cherry picked from commit 77a6c664de52f6a28910ab585a347ed0f4c2d899)

Review URL: https://codereview.chromium.org/2410353002 .

Cr-Commit-Position: refs/branch-heads/2883@{#46}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/48c4493746716ffec1fae380abc80583b6fc2326/remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java
[modify] https://crrev.com/48c4493746716ffec1fae380abc80583b6fc2326/remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65c8ec0c0d3d8d3c79096a2bba6ae3b80da2d951

commit 65c8ec0c0d3d8d3c79096a2bba6ae3b80da2d951
Author: Joe Downing <joedow@google.com>
Date: Tue Oct 11 22:44:30 2016

Update DesktopCanvas to allow over-panning when Soft Input Method is present.

My previous change allowed the user to 'over-pan' the desktop image such
that it can be pulled out from under any System UI present.  After using
the feature a bit and tqalking with other folks on the team, I think
this behavior should be restricted to only be allowed when a Soft Input
Method is present.

BUG= 654565 

Review-Url: https://codereview.chromium.org/2411503002
Cr-Commit-Position: refs/heads/master@{#424506}
(cherry picked from commit 99f909132e4756059b6414b723beadd72453a71c)

Review URL: https://codereview.chromium.org/2408343002 .

Cr-Commit-Position: refs/branch-heads/2883@{#47}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/65c8ec0c0d3d8d3c79096a2bba6ae3b80da2d951/remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java

When the keyboard is showing and the toolbar has faded out, the margin on the top doesn't go away. Is that a potential bug?

That sounds by design for this change.  The margin shouldn't disappear automatically.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65c8ec0c0d3d8d3c79096a2bba6ae3b80da2d951

commit 65c8ec0c0d3d8d3c79096a2bba6ae3b80da2d951
Author: Joe Downing <joedow@google.com>
Date: Tue Oct 11 22:44:30 2016

Update DesktopCanvas to allow over-panning when Soft Input Method is present.

My previous change allowed the user to 'over-pan' the desktop image such
that it can be pulled out from under any System UI present.  After using
the feature a bit and tqalking with other folks on the team, I think
this behavior should be restricted to only be allowed when a Soft Input
Method is present.

BUG= 654565 

Review-Url: https://codereview.chromium.org/2411503002
Cr-Commit-Position: refs/heads/master@{#424506}
(cherry picked from commit 99f909132e4756059b6414b723beadd72453a71c)

Review URL: https://codereview.chromium.org/2408343002 .

Cr-Commit-Position: refs/branch-heads/2883@{#47}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/65c8ec0c0d3d8d3c79096a2bba6ae3b80da2d951/remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48c4493746716ffec1fae380abc80583b6fc2326

commit 48c4493746716ffec1fae380abc80583b6fc2326
Author: Joe Downing <joedow@google.com>
Date: Tue Oct 11 22:23:14 2016

Moving logic for System UI state changes into DesktopCanvas class

Most of the logic for reacting to System UI changes was already in the
DesktopCanvaqs class however there was one boolean check outside of
that.  Instead of adding yet another parameter to the DesktopCanvas
handler method, I now pass the event parameters themselves.  This will
allow future changes to the logic to be made solely in the DesktopCanvas
class.

BUG= 654565 

Review-Url: https://codereview.chromium.org/2410613003
Cr-Commit-Position: refs/heads/master@{#424284}
(cherry picked from commit 77a6c664de52f6a28910ab585a347ed0f4c2d899)

Review URL: https://codereview.chromium.org/2410353002 .

Cr-Commit-Position: refs/branch-heads/2883@{#46}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/48c4493746716ffec1fae380abc80583b6fc2326/remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java
[modify] https://crrev.com/48c4493746716ffec1fae380abc80583b6fc2326/remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java

verified new behavior in 56.0.2908.0

[Automated comment] removing mislabelled merge-merged-2840

[Automated comment] removing mislabelled merge-merged-2840