ARC++ makes Task Manager much less useful |
|||||||||
Issue descriptionGoogle Chrome 53.0.2785.144 (Official Build) (64-bit) Revision 79ce8e9f7864f5dbb6e07f3ba7b9a05943acb912-refs/branch-heads/2785@{#931} What steps will reproduce the problem? (1) Enable the play store (ARC++). (2) Open the Chrome Task Manager (Search+Esc) What is the expected output? I see chrome tabs. What do you see instead? I see 30+ android processes, and a few chrome ones. I think we need some kind of filter that hides the system level arc++ stuff. It's really hard to use the task manager once you enable arc because all your tabs are hidden inside the sea of android tasks.
,
Nov 28 2016
I disagree somewhat that we already have chrome tabs and all the background processes and android only adds so many. But I agree we are piling on to a situation where we already have an issue that we have too many processes to comfortably browse.
,
Dec 6 2016
Hiding Android System processes makes more sense to me. We don't list ChromeOS system processes like frecon, dbus-daemon, cryptohomed, .... Android vold, surfaceflinger, zygote, ... looks to fall in the same category to me.
,
Dec 6 2016
That sounds good to me. I disagree with #2, on a brand new Chromebook there's maybe 3 things in the task list, as soon as I enable ARC++ there's 20-30 things, even when no Android apps are open there's a huge list of Android system services running in there. If there's no tabs open the task list should have a tiny number of things (Browser, GPU, maybe 1-2 Android system things).
,
Dec 6 2016
The purpose to add these daemon processes is to track hidden cpu or memory usage. I agree that they seem to be too many in numbers and think of several options for improvement. 1. An option checkbox for hiding or showing these processes, default hiding all pros: Intuitive. Users could select what they want. cons: Make the user interface more complex. 2. Show the processes with cpu / memory usage higher than some threshold. pros: Show only what we want to know. Keep the process list clean at most of the time. cons: Some processes might appear and disappear due to resource usage change and the behavior might confuse the user. 3. Keep a process names white-list for display pros: The process list is stable. No processes would randomly appear and disappear. We can decide what to monitor. cons: Need efforts to review and maintain the list. Developers might get confused why some of them are shown while some are not. I personally like idea 3 most. The android processes are still needed because some of them would consume much resources in certain situation. For example, the surfaceflinger. Most of them are quiet. I think the users would like to know about what processes consume the system resources no matter where they come from.
,
Dec 13 2016
Hi Hiro, could you triage this UI request.
,
Dec 13 2016
Per triage: sgabriel@ are there any plans to change the task manager in the near future? I'm ok with option 3 for now.
,
Dec 20 2016
No plan as far as I know to change the task manager. Ok with option 3 as well if eng is cool with it.
,
Dec 20 2016
uekawa@ is this something your team can work on? If not please kick it back to me.
,
Jan 23 2017
,
Jan 24 2017
I'm having a look at this now. Which processes should be white-listed? Another concern I have is that if a not shown process misbehaves and eats CPU, it might be confusing. Personally I would want to be able to kill the process in that situation.
,
Feb 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13452f1a1149352dc13b53027bbceac54ed217e6 commit 13452f1a1149352dc13b53027bbceac54ed217e6 Author: edcourtney <edcourtney@chromium.org> Date: Tue Feb 07 10:11:12 2017 [task_manager] Add ARC process whitelist. Filter which Android processes we display in the task manager by an explicit whitelist and based on ProcessState. BUG= 654564 Review-Url: https://codereview.chromium.org/2655633002 Cr-Commit-Position: refs/heads/master@{#448580} [modify] https://crrev.com/13452f1a1149352dc13b53027bbceac54ed217e6/chrome/browser/BUILD.gn [add] https://crrev.com/13452f1a1149352dc13b53027bbceac54ed217e6/chrome/browser/task_manager/providers/arc/arc_process_filter.cc [add] https://crrev.com/13452f1a1149352dc13b53027bbceac54ed217e6/chrome/browser/task_manager/providers/arc/arc_process_filter.h [add] https://crrev.com/13452f1a1149352dc13b53027bbceac54ed217e6/chrome/browser/task_manager/providers/arc/arc_process_filter_unittest.cc [modify] https://crrev.com/13452f1a1149352dc13b53027bbceac54ed217e6/chrome/browser/task_manager/providers/arc/arc_process_task_provider.cc [modify] https://crrev.com/13452f1a1149352dc13b53027bbceac54ed217e6/chrome/browser/task_manager/providers/arc/arc_process_task_provider.h [modify] https://crrev.com/13452f1a1149352dc13b53027bbceac54ed217e6/chrome/test/BUILD.gn
,
Feb 7 2017
This removes the majority of the useless processes, with an exception for surface flinger (as suggested earlier in the bug). I wasn't entirely sure exactly what to whitelist for, so feel free to modify the whitelist and/or change the ProcessStates that are implicitly allowed. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by esprehn@chromium.org
, Oct 10 2016