New issue
Advanced search Search tips

Issue 654554 link

Starred by 3 users
Status: Fixed
Owner: ----
Closed: Nov 26
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[SPv2] WebPagePopupImpl fails isAcceleratedCompositingActive

Project Member Reported by pdr@chromium.org, Oct 10 2016 
SPV2 hits a dcheck in WebPagePopupImpl due to no layer.

The following 55 tests crash:
fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar.html
fast/forms/color/color-suggestion-picker-appearance-zoom200.html
fast/forms/color/color-suggestion-picker-two-row-appearance.html
fast/forms/color/color-suggestion-picker-one-row-appearance.html
fast/forms/color/color-suggestion-picker-appearance-zoom125.html
fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html
fast/forms/select-popup/popup-menu-appearance-minimum-font.html
fast/forms/select-popup/popup-menu-appearance-transform.html
fast/forms/select-popup/popup-menu-appearance-zoom090.html
fast/forms/select-popup/popup-menu-appearance-texttransform.html
fast/forms/select-popup/popup-menu-appearance-many.html
fast/forms/select-popup/popup-menu-appearance.html
fast/forms/select-popup/popup-menu-appearance-long.html
fast/forms/select-popup/popup-menu-appearance-fractional-width.html
fast/forms/select-popup/popup-menu-appearance-rtl.html
fast/forms/select-popup/popup-menu-appearance-empty.html
fast/forms/select-popup/popup-menu-appearance-single-option.html
fast/forms/select-popup/popup-menu-appearance-tall.html
fast/forms/select-popup/popup-menu-appearance-zoom.html
fast/forms/select-popup/popup-menu-appearance-styled.html
fast/forms/select-popup/popup-menu-appearance-rtl-default.html
fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl.html
fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar.html
fast/forms/suggestion-picker/time-suggestion-picker-appearance.html
fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance.html
fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew.html
fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar.html
fast/forms/color/color-suggestion-picker-appearance.html
fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl.html
fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl.html
fast/forms/suggestion-picker/date-suggestion-picker-appearance-zoom125.html
fast/forms/suggestion-picker/date-suggestion-picker-appearance-zoom200.html
fast/forms/suggestion-picker/week-suggestion-picker-appearance.html
fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew.html
fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar.html
fast/forms/suggestion-picker/month-suggestion-picker-appearance.html
fast/forms/suggestion-picker/date-suggestion-picker-appearance.html
fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar.html
fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl.html
fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl.html
fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html
fast/forms/calendar-picker/calendar-picker-appearance-required.html
fast/forms/calendar-picker/calendar-picker-appearance-zoom125.html
fast/forms/calendar-picker/month-picker-appearance-step.html
fast/forms/calendar-picker/calendar-picker-appearance-step.html
fast/forms/calendar-picker/calendar-picker-appearance-minimum-date.html
fast/forms/calendar-picker/week-picker-appearance.html
fast/forms/calendar-picker/week-picker-appearance-step.html
fast/forms/calendar-picker/calendar-picker-appearance-ar.html
fast/forms/calendar-picker/calendar-picker-appearance-zoom200.html
fast/forms/calendar-picker/calendar-picker-appearance.html
fast/forms/calendar-picker/calendar-picker-appearance-ru.html
fast/forms/calendar-picker/month-picker-appearance.html
fast/forms/select/input-select-after-resize.html
compositing/overflow/update-widget-positions-on-nested-frames-and-scrollers.html
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4019a49c392955aebccee5de6444551de71760a7

commit 4019a49c392955aebccee5de6444551de71760a7
Author: pdr <pdr@chromium.org>
Date: Tue Oct 11 01:02:48 2016

Suppress 55 spv2 test failures from lack of popup support

[1] recently added input-select-after-resize.html which crashes with
spv2. I found 54 other crashes with the same root cause and have
triaged them in FlagExpectations/enable-slimming-paint-v2.

These failures can be reproduced with:
run-webkit-tests --additional-driver-flag=--enable-slimming-paint-v2

[1] https://chromium.googlesource.com/chromium/src/+/6b08cd23a5bbe4e1d95bb7e0431fc743e6b0180c

BUG= 654554 

Review-Url: https://codereview.chromium.org/2411463002
Cr-Commit-Position: refs/heads/master@{#424317}

[modify] https://crrev.com/4019a49c392955aebccee5de6444551de71760a7/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
Project Member

Comment 2 by sheriffbot@chromium.org, Oct 11 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by schenney@chromium.org, Oct 11 2017

Labels: -Hotlist-Recharge-Cold PaintTeamTriaged-20171011 BugSource-Team
Status: Available (was: Untriaged)
Project Member

Comment 4 by sheriffbot@chromium.org, Oct 11

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by schenney@chromium.org, Oct 11

Status: Available (was: Untriaged)

Comment 6 by wangxianzhu@chromium.org, Nov 26

Summary: [SPv2] fast/forms/select-popup/popup-menu-appearance-tall.html fail (was: WebPagePopupImpl fails isAcceleratedCompositingActive with spv2)
Now there is only one failing test (fast/forms/select-popup/popup-menu-appearance-tall.html) associated with this bug, and the failure is due to different rendering instead of DCHECK failure.

Comment 7 by wangxianzhu@chromium.org, Nov 26

Status: Fixed (was: Available)
Summary: [SPv2] WebPagePopupImpl fails isAcceleratedCompositingActive (was: [SPv2] fast/forms/select-popup/popup-menu-appearance-tall.html fail)
Actually fast/forms/select-popup/popup-menu-appearance-tall.html is producing the same result with and without SPv2. The failure for non-SPv2 is tracked by bug 543369.
►

Sign in to add a comment