New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 654539 link

Starred by 5 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Hide Chrome actions in notifications shown for WebAPKs

Project Member Reported by sbirch@chromium.org, Oct 10 2016

Issue description

We might do this already, but just to make sure:

We should hide the "Site Settings" action that Chrome puts on web notifications when they're shown through a WebAPK. The action will take you to site settings, when you should be managing the notification settings of a WebAPK through Android.

(Peter, not sure whether this is more in your or Xi's wheelhouse, but Xi's out right now.)

 

Comment 1 by owe...@chromium.org, Oct 10 2016

Cc: peter@chromium.org
We actually did work to make the "site settings action appear. See  Issue 610156 . Should be easy to get rid of the "site settings action"

Comment 3 by peter@chromium.org, Oct 17 2016

+1 on removing it! This is also the direction we got from Roma in a meeting earlier this year.

As hacky as it may be, what are your thoughts on having something like NotificationSystemStatusUtil.determineAppNotificationStatus() in the WebAPK? It would be fantastic if we could get insight in notification disable rates for WebAPKs vs. regular Chrome notifications.
We can definitely have something like this in the WebAPK. I am going to punt this task to next week.

It is not very clear in the bug description. This change is part of Sam's desire for a larger change where WebAPKs bypass site settings. For instance, a WebAPK for https://tests.peter.sh/notification-generator/ would ignore site settings for https://tests.peter.sh This larger change sounds complicated and will require a lot of time to figure out how to do properly
Owner: gonzalon@chromium.org
I just talked to Sam.

Currently, it is possible to disable WebAPK notifications via Chrome settings. However, we want to guide users to disable notifications via Android settings so we should remove the "Site Settings" action from notifications.

There is one on both the front and the back of the notification

Comment 6 by rolfe@chromium.org, Jan 20 2017

Cool. Just to confirm, users can still get to the WebAPK OS-level notification permissions right? (I think it's long press to get to the back part and tap the app icon.)

Comment 7 by sbirch@chromium.org, Jan 20 2017

Yup. It's pretty visible since M, and possible in settings going back to JB. (See slide: https://docs.google.com/presentation/d/1X6_1YzdnfHkVjmQWqvT8HnhQ4CB09y146w9XLwYFDYE/edit#slide=id.g17f5158747_0_0)

Comment 8 by peter@chromium.org, Jan 27 2017

Components: UI>Notifications

Comment 9 by owe...@chromium.org, Jan 28 2017

Labels: -Pri-2 Pri-1
Bumping to P1 since this is marked as launch blocking for WebAPKs. (I'm OK if we want to call this non-launch blocking, but while it is officially marked as blocking it should be P1)
Blocking: -629181
Labels: -Pri-1 M-58 Pri-2
Punting from v0.

Comment 11 by rolfe@chromium.org, Mar 29 2017

Cc: -rolfe@chromium.org chowse@chromium.org
Removing myself and adding chowse@ as the Web Platform design contact for input if needed.
Owner: ----
Status: Available (was: Assigned)

Comment 13 by hanxi@chromium.org, Apr 20 2017

Is there any agreement made on this bug? If yes, I will go ahead to remove the site setting on the notification of WebAPK.
I'm also in favor. I don't believe anybody is against this, so if you don't hear anyone object I'd go ahead.

Comment 15 by hanxi@chromium.org, Apr 21 2017

Sounds great. Thanks Owen! A CL is on progress: https://codereview.chromium.org/2826223002/.
Project Member

Comment 16 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4df7199f5d2cafd62bf9c9d016caa341230139ca

commit 4df7199f5d2cafd62bf9c9d016caa341230139ca
Author: hanxi <hanxi@chromium.org>
Date: Fri Apr 28 02:15:25 2017

Hide Chrome actions in notifications shown for WebAPKs

This CL hides the "Site setting" action when notifications are shown by WebAPKs.
The "additional settings in the app" link will be removed from the notification
settings for WebAPKs in the System UI in Android O. Before Android O, the
settings gear to open app-specific settings shown on the rear of a notification
following a long-press will be gone as well.

BUG=654539

Review-Url: https://codereview.chromium.org/2826223002
Cr-Commit-Position: refs/heads/master@{#467843}

[modify] https://crrev.com/4df7199f5d2cafd62bf9c9d016caa341230139ca/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java
[modify] https://crrev.com/4df7199f5d2cafd62bf9c9d016caa341230139ca/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java
[modify] https://crrev.com/4df7199f5d2cafd62bf9c9d016caa341230139ca/chrome/android/webapk/shell_apk/AndroidManifest.xml
[modify] https://crrev.com/4df7199f5d2cafd62bf9c9d016caa341230139ca/chrome/android/webapk/shell_apk/BUILD.gn
[modify] https://crrev.com/4df7199f5d2cafd62bf9c9d016caa341230139ca/chrome/android/webapk/shell_apk/shell_apk_version.gni
[delete] https://crrev.com/5dad32e367d077bf8b84f1700a6cd00e74a20cc1/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/NotificationSettingsLauncherActivity.java

Comment 17 by hanxi@chromium.org, Apr 28 2017

Owner: hanxi@chromium.org
Status: Assigned (was: Available)
The update to shell_apk_version.gni was reverted due to the revert of CL https://codereview.chromium.org/2845943006/), the version number should be updated in a follow up CL.
This is fixed, right?

Comment 19 by hanxi@chromium.org, May 11 2017

Only the first part is fixed, and this bug also involves changes in Chrome's setting, see comment#5.

Sign in to add a comment