New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 654536 link

Starred by 20 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: Add initiator and priority to HAR export

Project Member Reported by paulir...@chromium.org, Oct 10 2016

Issue description

These two signals are massively valuable and would be of tremendous help to tools that are analyzing network traffic.

Lighthouse can generate performance metrics off a trace and Network domain protocol traffic (https://github.com/GoogleChrome/lighthouse#trace-processing). It requires the full network domain event stream for the initiator and priority. 
If this information was in a HAR, then this analysis would be much more accessible.

The leading tool for automated HAR exports from chrome actually includes initiator and priority already: https://github.com/cyrus-and/chrome-har-capturer
(In fact, I pointed chowse to this, as he need it to work on the network-initiator prototype)

Can we add these in as custom fields?

 

Comment 1 by kayce@google.com, Oct 13 2016

Labels: DevTools-User-Facing

Comment 2 by allada@chromium.org, Jul 20 2017

Cc: igrigo...@chromium.org caseq@chromium.org
 Issue 230828  has been merged into this issue.
Status: WontFix (was: Assigned)
Closing due to lack of priority / resources.
Owner: paulir...@chromium.org
Status: Assigned (was: WontFix)
Owner: jarhar@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0913e140518c81b10bab563c3f8d24aaee1bd4c4

commit 0913e140518c81b10bab563c3f8d24aaee1bd4c4
Author: Joey Arhar <jarhar@chromium.org>
Date: Wed Sep 26 20:20:09 2018

[DevTools] Add initiator and priority to HAR importing and exporting

This patch adds two fields, _initiator and _priority, to each entry in
each HAR file. I chose to use underscores in the exported names because
they are not part of the HAR standard and the other non-standard fields
we export also have underscores.

I tested by importing this new type of HAR file in chrome 69, importing
a chrome 69 HAR file with this new patch applied, and by exporting and
importing with all types of initiators.

Bug:  654536 
Change-Id: Ibd96eb6374900f29b03880d3292933b539708f18
Reviewed-on: https://chromium-review.googlesource.com/1232374
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594456}
[modify] https://crrev.com/0913e140518c81b10bab563c3f8d24aaee1bd4c4/third_party/WebKit/LayoutTests/http/tests/devtools/resource-har-conversion-expected.txt
[modify] https://crrev.com/0913e140518c81b10bab563c3f8d24aaee1bd4c4/third_party/WebKit/LayoutTests/http/tests/devtools/resource-har-headers-expected.txt
[modify] https://crrev.com/0913e140518c81b10bab563c3f8d24aaee1bd4c4/third_party/WebKit/LayoutTests/http/tests/devtools/resource-har-headers.js
[modify] https://crrev.com/0913e140518c81b10bab563c3f8d24aaee1bd4c4/third_party/WebKit/LayoutTests/http/tests/devtools/resource-parameters-expected.txt
[modify] https://crrev.com/0913e140518c81b10bab563c3f8d24aaee1bd4c4/third_party/WebKit/LayoutTests/http/tests/devtools/resource-parameters-ipv6-expected.txt
[modify] https://crrev.com/0913e140518c81b10bab563c3f8d24aaee1bd4c4/third_party/blink/renderer/devtools/front_end/har_importer/HARFormat.js
[modify] https://crrev.com/0913e140518c81b10bab563c3f8d24aaee1bd4c4/third_party/blink/renderer/devtools/front_end/har_importer/HARImporter.js
[modify] https://crrev.com/0913e140518c81b10bab563c3f8d24aaee1bd4c4/third_party/blink/renderer/devtools/front_end/network_test_runner/NetworkTestRunner.js
[modify] https://crrev.com/0913e140518c81b10bab563c3f8d24aaee1bd4c4/third_party/blink/renderer/devtools/front_end/sdk/HARLog.js

Status: Fixed (was: Started)

Sign in to add a comment