New issue
Advanced search Search tips

Issue 654528 link

Starred by 1 user
Status: Fixed
Owner:
sonnyrao@chromium.org
Closed: Oct 2016
Cc:
kinaba@chromium.org
chirantan@chromium.org
julanhsu@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

manifest-internal/external_full.xml out of sync with manifest/full.xml

Project Member Reported by dgarr...@chromium.org, Oct 10 2016 
https://chrome-internal-review.googlesource.com/#/c/280917/

This CL got the external_full.xml and manifests/full.xml out of sync with each other. Is there another CL that just hasn't landed yet? If so, please get it chumped now.

Filing  crbug.com/654527  to add CQ tests in addition to the presubmit checks.

Comment 1 by sonnyrao@chromium.org, Oct 10 2016 

Ah, yeah that's my bad, will put up a CL and chump it

Comment 2 by sonnyrao@chromium.org, Oct 10 2016

Cc: chirantan@chromium.org julanhsu@chromium.org kinaba@chromium.org
Adding current sheriffs to CC

Ok I'm looking at this and it seems like manifests/full.xml includes external_full.xml -- so I'm not sure I understand how it got out of sync -- maybe I'm looking at the wrong repo or something?

Comment 3 by dgarr...@chromium.org, Oct 10 2016 

These are the two that should stay in sync.

$REPO/manifest/full.xml
$REPO/manifest-internal/external_full.xml

Comment 4 by sonnyrao@chromium.org, Oct 10 2016

Status: Fixed (was: Untriaged)
chumped -- should be fixed now
►

Sign in to add a comment